restore signal handlers after wait for signals is done #6400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
approved these changes
May 20, 2022
graingert
deleted the
restore-signal-handler-after-wait-for-signals-is-done
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
wait_for_signalsis cancelled - eg by theidle-timeout=1sexpiring it left thewait_for_signals.handle_signalin placethis is usually not a problem because it's only called as the first operation of a brand new process. However when it's called via
CliRunner().invoke(this causes the signal handler to be set for all subsequent tests which impacts using Ctrl+C during development.pre-commit run --all-files