Improve tests that watch for subprocess logs #6461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests like dask#6395 will fail (timeout) because a log statement doesn't get printed, but since you never get to see what _was_ printed, CI failuers are hard to debug. Adds a `wait_for_log_line` helper that tees the output to stdout, so you can at least see what happened.
Unit Test Results 15 files + 3 15 suites +3 6h 34m 35s ⏱️ + 1h 35m 4s For more details on these failures and errors, see this check. Results for commit 65185c8. ± Comparison against base commit 0cd45ef. |
|
Yup. Looks good to me. Thanks @gjoseph92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests like #6395 will fail (timeout) because a log statement doesn't get printed, but since you never get to see what was printed, CI failuers are hard to debug.
Adds a
wait_for_log_linehelper that tees the output to stdout, so you can at least see what happened.pre-commit run --all-files