Miscellaneous flake8-bugbear issues
#6814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files + 1 15 suites +1 6h 10m 30s ⏱️ + 12m 55s For more details on these failures and errors, see this check. Results for commit 7cdd058. ± Comparison against base commit 192a8bb. ♻️ This comment has been updated with latest results. |
gjoseph92
approved these changes
Aug 3, 2022
hendrikmakait
force-pushed
the
flake8-bugbear-misc
branch
from
50881d9
to
7cdd058
Compare
crusaderky
approved these changes
Aug 4, 2022
hendrikmakait
commented
Aug 4, 2022
| @@ -837,7 +837,7 @@ def __init__( | |||
| # It's a LocalCluster or LocalCluster-compatible object | |||
| self.cluster = address | |||
| status = self.cluster.status | |||
| if status and status in [Status.closed, Status.closing]: | |||
| if status in (Status.closed, Status.closing): | |||
There was a problem hiding this comment.
Good catch, thanks @crusaderky!
gjoseph92
pushed a commit
to gjoseph92/distributed
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses pre-commit failures in #6809
pre-commit run --all-files