Enable support for tornado 6.2 #7134
Conversation
| @@ -347,7 +347,7 @@ def key(ws): | |||
| adaptive = cluster.adapt(minimum=1) | |||
| await adaptive.adapt() | |||
|
|
|||
| while len(cluster.scheduler.workers) == 4: | |||
| while len(cluster.scheduler.workers) >= 3: | |||
There was a problem hiding this comment.
This is unrelated to the tornado changes, but this test was intermittently failing locally.
We're attempting to scale down from four to two workers (based on the grouping key, IIUC), but we might not have torn down both additional workers by the time this loop exits if just checking that we no longer have four workers.
I can spin this out into a separate PR if preferable.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 32m 2s ⏱️ - 1m 12s For more details on these failures, see this check. Results for commit ff6f673. ± Comparison against base commit 803c624. ♻️ This comment has been updated with latest results. |
|
Windows fail appears to be flaky/bad test #7135; |
|
Since I didn't manage to get this into 2022.10.2, I'd like to have a more comprehensive go this time. As it stands, this PR just kicks the can down the road wrt deprecated functionality: distributed internally doesn't use the deprecated functionality so I only needed to touch tests. Depending on whether we feel the deprecation cycle has been long enough (#6680 came in in July) the larger set of changes would be to remove all the deprecated functionality in Before I head in this direction, do we want that now? |
|
I still see If this is just about ripping out all deprecated calls concerning the loop runner, I'm OK with this. afaik, most downstream consumers were migrated. @jacobtomlinson I believe you were involved in these efforts. |
distributed/tests/test_client.py
Outdated
| @@ -5538,23 +5538,18 @@ async def test_future_auto_inform(c, s, a, b): | |||
| await asyncio.sleep(0.01) | |||
|
|
|||
|
|
|||
| @pytest.mark.filterwarnings("ignore:There is no current event loop:DeprecationWarning") | |||
| @pytest.mark.filterwarnings("ignore:make_current is deprecated:DeprecationWarning") | |||
| @pytest.mark.filterwarnings("ignore:clear_current is deprecated:DeprecationWarning") | |||
| def test_client_async_before_loop_starts(cleanup): | |||
There was a problem hiding this comment.
the name of the test doesn't match what's done in the body of the test anymore
I opened #7240 to remove the calls from |
tornado 6.2 deprecates functionality that relies on deprecated asyncio calls (get_event_loop and friends); a few tests still use a pattern of implicitly creating a new loop (and test that appropriate deprecation warnings are uttered), so just catch these new tornado warnings for now, until the functionality is removed in distributed.
wence-
force-pushed
the
wence/fix/tornado-dep
branch
from
05e4496
to
b60d5bd
Compare
|
Let me fix the lint errors, but I am pretty sure this is not yet ready unfortunately. |
hayesgb
added
the
enhancement
|
FWIW, I've had a go at trying to understand how |
|
closed and incorporated by #7286 |
Most of the work in deprecation was done as part of #6680; with
tornado 6.2 in the few tests that still rely on creating an event loop
we must catch deprecation warnings from tornado in addition to those
from asyncio.
I suppose that the next step would be to remove support in
LoopRunnerand friends for this deprecated functionality, and thencull the tests that are checking for this behaviour, but I have not
done this here.
This ports over the version pin changes from #6991.
Closes #6669.
pre-commit run --all-files