Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bokeh upper bound #7413

Merged
merged 7 commits into from
Mar 30, 2023
Merged

Conversation

jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Dec 16, 2022

Closes #7173
Closes #7414
Closes #7362

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  +       1         26 suites  +1   14h 14m 16s ⏱️ + 2h 18m 44s
  3 543 tests ±       0    3 435 ✔️ +       1     105 💤 +    1  3  - 2 
44 806 runs  +1 282  42 592 ✔️ +1 109  2 210 💤 +174  4  - 1 

For more details on these failures, see this check.

Results for commit 75c90d0. ± Comparison against base commit f102357.

This pull request skips 1 test.
distributed.protocol.tests.test_protocol ‑ test_large_messages

♻️ This comment has been updated with latest results.

@jrbourbeau jrbourbeau changed the title [DNM] Remove bokeh upper bound Remove bokeh upper bound Mar 29, 2023
Copy link
Member Author

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I tried out bokeh=3.1 and things seem good. I looked at the dashboard, performance reports, and the labextension. This PR removed the bokeh version upper bound constraint, but we disallow bokeh=3.0.x

@mrocklin
Copy link
Member

mrocklin commented Mar 29, 2023 via email

Copy link
Member

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thank you @jrbourbeau

@fjetter
Copy link
Member

fjetter commented Mar 31, 2023

This appears to have caused some breakage #7732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants