-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bokeh
upper bound
#7413
Remove bokeh
upper bound
#7413
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 26 files + 1 26 suites +1 14h 14m 16s ⏱️ + 2h 18m 44s For more details on these failures, see this check. Results for commit 75c90d0. ± Comparison against base commit f102357. This pull request skips 1 test.
♻️ This comment has been updated with latest results. |
…e-bokeh-upper-bound
…e-bokeh-upper-bound
…e-bokeh-upper-bound
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I tried out bokeh=3.1
and things seem good. I looked at the dashboard, performance reports, and the labextension. This PR removed the bokeh
version upper bound constraint, but we disallow bokeh=3.0.x
Woo!
…On Wed, Mar 29, 2023 at 5:02 PM James Bourbeau ***@***.***> wrote:
***@***.**** commented on this pull request.
Okay, I tried out bokeh=3.1 and things seem good. I looked at the
dashboard, performance reports, and the labextension. This PR removed the
bokeh version upper bound constraint, but we disallow bokeh=3.0.x
—
Reply to this email directly, view it on GitHub
<#7413 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTA4D5JQUL5HLZYXARDW6SWNVANCNFSM6AAAAAATBQDUAI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Thank you @jrbourbeau
This appears to have caused some breakage #7732 |
Closes #7173
Closes #7414
Closes #7362