support get_worker() and worker_client() in async tasks #7844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
changed the title
|
this will also need a test for |
|
this is like #5517 but only sets the contextvar when running user tasks |
graingert
commented
May 18, 2023
graingert
commented
May 18, 2023
| yield client | ||
|
|
||
| if separate_thread: | ||
| rejoin() |
There was a problem hiding this comment.
previously this didn't rejoin if there was an exception in with worker_client():
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 26 files ± 0 26 suites ±0 14h 48m 29s ⏱️ - 24m 51s For more details on these failures, see this check. Results for commit 8e092cd. ± Comparison against base commit e887fde. |
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5513
pre-commit run --all-files