-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support get_worker() and worker_client() in async tasks #7844
Conversation
this will also need a test for |
this is like #5517 but only sets the contextvar when running user tasks |
yield client | ||
|
||
if separate_thread: | ||
rejoin() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously this didn't rejoin if there was an exception in with worker_client():
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 26 files ± 0 26 suites ±0 14h 48m 29s ⏱️ - 24m 51s For more details on these failures, see this check. Results for commit 8e092cd. ± Comparison against base commit e887fde. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @graingert!
Closes #5513
pre-commit run --all-files