Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed default in description of LocalCluster > scheduler_port #8073

Merged
merged 1 commit into from Aug 7, 2023
Merged

fixed default in description of LocalCluster > scheduler_port #8073

merged 1 commit into from Aug 7, 2023

Conversation

Danferno
Copy link
Contributor

@Danferno Danferno commented Aug 4, 2023

New description:
Port of the scheduler. Use 0 to choose a random port (default). 8786 is a common choice.

Closes #8060

  • Tests added / passed
  • Passes pre-commit run --all-files

New description:
Port of the scheduler. Use 0 to choose a random port (default). 8786 is a common choice.
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±0         20 suites  ±0   12h 7m 3s ⏱️ + 40m 11s
  3 752 tests ±0    3 642 ✔️ +1     104 💤 ±0  6  - 1 
36 477 runs  ±0  34 807 ✔️ +3  1 663 💤 ±0  7  - 3 

For more details on these failures, see this check.

Results for commit c1470f7. ± Comparison against base commit eb297b3.

Copy link
Collaborator

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Danferno: Thanks for fixing the documentation!

@hendrikmakait hendrikmakait merged commit 4c4748a into dask:main Aug 7, 2023
20 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalCluster: discrepancy default option code & documentation
4 participants