Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't capture functools frames in code #8146

Merged
merged 1 commit into from Aug 31, 2023

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Aug 31, 2023

Suppress functools frames in distributed.spans.Span.code

@mrocklin
Copy link
Member

+1 from me. Thanks Guido

@crusaderky crusaderky marked this pull request as draft August 31, 2023 16:25
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     21 files  ±  0       21 suites  ±0   1h 17m 26s ⏱️ -35s
3 340 tests ±  0  3 106 ✔️  -   1  231 💤 ±0  1 +1    2 🔥 ±0 
6 822 runs  +12  5 972 ✔️ +14  827 💤  - 3  1 +1  22 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 5bb23ee. ± Comparison against base commit ec40daa.

@crusaderky crusaderky marked this pull request as ready for review August 31, 2023 16:37
@crusaderky crusaderky merged commit 5e50547 into dask:main Aug 31, 2023
10 of 29 checks passed
@crusaderky crusaderky deleted the no_functools_in_code branch August 31, 2023 16:37
@crusaderky crusaderky self-assigned this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants