Hide pytest from code snippets #8198
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 19 files - 2 19 suites - 2 8h 55m 1s ⏱️ - 1h 30m 48s For more details on these failures, see this check. Results for commit ec9aa85. ± Comparison against base commit b6333df. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Thanks @crusaderky. This seems reasonable to me, though the distributed/tests/test_client.py::test_computation_object_code_dask_compute failure looks legitimate
distributed/distributed.yaml
Outdated
| @@ -274,6 +274,7 @@ distributed: | |||
| max-history: 100 | |||
| nframes: 0 | |||
| ignore-modules: | |||
| - _pytest | |||
There was a problem hiding this comment.
Just for my own understanding, why _pytest and not pytest?
There was a problem hiding this comment.
https://github.com/pytest-dev/pytest/blob/main/src/pytest/__init__.py doesn't have any function defs and so won't appear in any frames
There was a problem hiding this comment.
all the function defs are in https://github.com/pytest-dev/pytest/tree/main/src/_pytest
crusaderky
force-pushed
the
no_pytest_code
branch
from
2f37f1b
to
cc133fb
Compare
|
It turns out it was quite a bit more involved than the original one-liner. It's ready for review again. |
| - py\.test # `py.test` shell command | ||
| - pytest-script\.py # `pytest` shell command in Windows | ||
| - _pytest # pytest implementation | ||
| - pycharm # Run pytest from PyCharm GUI |
There was a problem hiding this comment.
Could someone with vscode please run test_client.py and see if there are any regressions in the code tests?
|
I verified with vscode and added the relevant ignores. I also incorporated #8204 |
Clean up code snippets when pytest starts a cluster, e.g. coiled/benchmarks: