New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Python 3.12 #8223
Support for Python 3.12 #8223
Conversation
877d5d7
to
92cdfa1
Compare
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files + 4 25 suites +4 13h 27m 18s ⏱️ + 3h 8m 27s For more details on these failures, see this check. Results for commit cfbc37a. ± Comparison against base commit b49c0bb. ♻️ This comment has been updated with latest results. |
43028e9
to
92cf0de
Compare
…he atexit handler is called
5f38b89
to
9110869
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved several unrelated changes to different PRs.
Outstanding comments below:
I've reverted the gilknocker changes and moved them to #8263. I've also reverted the pyarrow import changes and was going to open a separate PR for them (main...crusaderky:distributed:no_pyarrow) but then I realised that pyarrow is a dependency in the dask conda package, which in turn is a dependency of so many other conda packages, so I'm not sure if we should bother dealing with the use case? A user would need to run the tests with pandas but with a strictly pip-installed version of dask and I wonder if anyone cares. CC @hendrikmakait for opinion |
Co-authored-by: crusaderky <crusaderky@gmail.com>
I doubt anybody cares right now, but it would be nice if setting up a Conda environment would not be a prerequisite for contributing to Dask. If this were a major maintenance burden I'd say let's scratch that, but since we have the patch ready, I see no reason for dropping the support for this right now. |
Actually, it's not that simple. Let's move the discussion to #8265. |
Current status
|
Closes #xxxx
pre-commit run --all-files