Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python 3.12 #8223

Merged
merged 38 commits into from Oct 13, 2023
Merged

Support for Python 3.12 #8223

merged 38 commits into from Oct 13, 2023

Conversation

graingert
Copy link
Member

@graingert graingert commented Oct 2, 2023

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       25 files  +       4         25 suites  +4   13h 27m 18s ⏱️ + 3h 8m 27s
  3 858 tests ±       0    3 737 ✔️ +       2     117 💤 ±    0    4  - 1 
44 927 runs  +7 627  42 779 ✔️ +7 313  2 122 💤 +310  26 +5 

For more details on these failures, see this check.

Results for commit cfbc37a. ± Comparison against base commit b49c0bb.

♻️ This comment has been updated with latest results.

@graingert graingert force-pushed the test-on-py312 branch 3 times, most recently from 43028e9 to 92cf0de Compare October 3, 2023 13:42
Copy link
Collaborator

@crusaderky crusaderky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved several unrelated changes to different PRs.
Outstanding comments below:

distributed/client.py Outdated Show resolved Hide resolved
distributed/nanny.py Outdated Show resolved Hide resolved
distributed/client.py Outdated Show resolved Hide resolved
distributed/protocol/serialize.py Show resolved Hide resolved
@crusaderky
Copy link
Collaborator

crusaderky commented Oct 12, 2023

I've reverted the gilknocker changes and moved them to #8263.

I've also reverted the pyarrow import changes and was going to open a separate PR for them (main...crusaderky:distributed:no_pyarrow) but then I realised that pyarrow is a dependency in the dask conda package, which in turn is a dependency of so many other conda packages, so I'm not sure if we should bother dealing with the use case? A user would need to run the tests with pandas but with a strictly pip-installed version of dask and I wonder if anyone cares. CC @hendrikmakait for opinion

Co-authored-by: crusaderky <crusaderky@gmail.com>
@hendrikmakait
Copy link
Member

I've also reverted the pyarrow import changes and was going to open a separate PR for them (main...crusaderky:distributed:no_pyarrow) but then I realised that pyarrow is a dependency in the dask conda package, which in turn is a dependency of so many other conda packages, so I'm not sure if we should bother dealing with the use case? A user would need to run the tests on a pure pypi environment and I doubt anyone cares.

I doubt anybody cares right now, but it would be nice if setting up a Conda environment would not be a prerequisite for contributing to Dask. If this were a major maintenance burden I'd say let's scratch that, but since we have the patch ready, I see no reason for dropping the support for this right now.

@crusaderky
Copy link
Collaborator

I've also reverted the pyarrow import changes and was going to open a separate PR for them (main...crusaderky:distributed:no_pyarrow) but then I realised that pyarrow is a dependency in the dask conda package, which in turn is a dependency of so many other conda packages, so I'm not sure if we should bother dealing with the use case? A user would need to run the tests on a pure pypi environment and I doubt anyone cares.

I doubt anybody cares right now, but it would be nice if setting up a Conda environment would not be a prerequisite for contributing to Dask. If this were a major maintenance burden I'd say let's scratch that, but since we have the patch ready, I see no reason for dropping the support for this right now.

Actually, it's not that simple. Let's move the discussion to #8265.

@jrbourbeau jrbourbeau mentioned this pull request Oct 12, 2023
8 tasks
@crusaderky crusaderky changed the title test on 3.12 Support for Python 3.12 Oct 12, 2023
@crusaderky
Copy link
Collaborator

Current status

@crusaderky crusaderky merged commit 5cedc47 into dask:main Oct 13, 2023
18 of 32 checks passed
@graingert graingert deleted the test-on-py312 branch October 13, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants