Use memoryview.nbytes when warning on large graph send #8268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files ±0 21 suites ±0 10h 55m 33s ⏱️ + 36m 42s For more details on these failures, see this check. Results for commit 4784ad9. ± Comparison against base commit b49c0bb. |
fjetter
approved these changes
Oct 13, 2023
graingert
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where the client would not warn when embedding a numpy or pandas constant with word size 8 worth up to 79.9 MB in the graph, whereas it should warn starting from 10 MB.
This is a blocker for Python 3.12 support, as
len(memoryview(a)), whereais a 0-dimensional numpy array, won't work anymore. (XREF #8223)