Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark fast tasks of tasks-based shuffle when dask-expr is enabled #8563

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Mar 8, 2024

The prefixes of fast tasks in dask-expr differ from legacy dask.dataframe.

@crusaderky crusaderky mentioned this pull request Mar 8, 2024
@crusaderky crusaderky changed the title Mark shuffle fast tasks in dask-expr Mark fast tasks of tasks-based shuffle when dask-expr is enabled Mar 8, 2024
@crusaderky crusaderky marked this pull request as ready for review March 8, 2024 16:15
@crusaderky crusaderky requested a review from fjetter as a code owner March 8, 2024 16:15
@crusaderky crusaderky requested a review from phofl March 8, 2024 16:16
Copy link
Collaborator

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those should be fine, they are equivalent with "split-shuffle" in dask/dask

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  +    26      27 suites  +26   10h 6m 51s ⏱️ + 10h 6m 27s
 4 048 tests + 4 003   3 935 ✅ + 3 927    110 💤 +   73   3 ❌ + 3 
50 828 runs  +50 783  48 482 ✅ +48 474  2 334 💤 +2 297  12 ❌ +12 

For more details on these failures, see this check.

Results for commit dfbadf1. ± Comparison against base commit e16a7af.

@crusaderky crusaderky merged commit 0438768 into dask:main Mar 8, 2024
20 of 34 checks passed
@crusaderky crusaderky deleted the dask-expr-durations branch March 8, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants