Make CI happy again #8560

milesgranger · 2024-03-07T12:45:32Z

xref: dask/dask-expr#945

Tried to split each 'fix' into it's own commit, I think some may need their own follow-up issue.

…inimal_version

…otocol xref dask/dask-expr#945

…efix != 1

distributed/protocol/tests/test_highlevelgraph.py

github-actions · 2024-03-07T14:30:04Z

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

27 files ± 0 27 suites ±0 10h 26m 24s ⏱️ + 1h 48m 13s
4 048 tests - 2 3 932 ✅ + 109 110 💤 - 3 6 ❌ - 108
50 828 runs +5 654 48 459 ✅ +6 274 2 336 💤 +180 33 ❌ - 800

For more details on these failures, see this check.

Results for commit 1ccfad6. ± Comparison against base commit f595c9e.

This pull request removes 2 tests.

distributed.cli.tests.test_dask_worker.test_listen_address_ipv6[tcp:..[ ‑ 1]:---nanny]
distributed.cli.tests.test_dask_worker.test_listen_address_ipv6[tcp:..[ ‑ 1]:---no-nanny]

♻️ This comment has been updated with latest results.

crusaderky · 2024-03-08T13:04:20Z

distributed/tests/test_scheduler.py

+    if dd._dask_expr_enabled():
+        pytest.skip("No split task in dask-expr")


@fjetter @phofl can I have a secondo opinion on this? Not sure I understand why we don't have this task in dask-expr. Are we missing a line in distributed.scheduler.default-task-durations?

XREF Ensure shuffle split default durations uses proper prefix #4991

There should be a split_task, e.g. the materialisation happens in TaskShuffle in _layer, but I have never look into how this is actually materialized

Same discussion for test_blocklist_shuffle_split

@hendrikmakait and I stumbled upon the root cause, dask-expr doesn't properly respect the context manager. I am preparing a fix at the moment, should be there in a minute

dask/dask-expr#958

pr is merged

@phofl I'm now seeing split-taskshuffle and split-stage. Are they both supposed to have 1us default-duration?

Yeah the naming is confusing and something we probably should fix, but it's ok conceptually

crusaderky · 2024-03-08T14:45:24Z

distributed/tests/test_steal.py

@@ -1011,6 +1011,7 @@ async def test_balance_with_longer_task(c, s, a, b):
    assert z.key in b.data


+@pytest.mark.xfail(reason="blocked is empty", raises=AssertionError)


Potential blocker.
Discussion on test_scheduler.py::test_default_task_duration_splits above.

distributed/shuffle/tests/test_shuffle.py

…milesgranger/fix-ci

crusaderky · 2024-03-08T16:02:41Z

I'm aiming to merge this PR with these tests still failing, as they are more involved:

test_dataframe_set_index_sync (test_dask_collections.py::test_dataframe_set_index_sync passes locally, fails on CI #8561)
test_default_task_duration_splits (Mark fast tasks of tasks-based shuffle when dask-expr is enabled #8563)
test_blocklist_shuffle_split (Mark fast tasks of tasks-based shuffle when dask-expr is enabled #8563)

hendrikmakait

Thanks, everyone! I agree with @crusaderky that we should go ahead and merge if nothing else pops up on CI.

milesgranger added 3 commits March 7, 2024 13:16

Fix test_basic_merge use of hash_join (no longer public)

31366e1

await computation in shuffle/tests/test_merge.py::test_merge

f4153fc

xfail p2p shuffle RuntimeError in shuffle/tests/test_merge.py::test_m…

c7b39e7

…inimal_version

milesgranger requested a review from fjetter as a code owner March 7, 2024 12:45

milesgranger force-pushed the milesgranger/fix-ci branch from a549bdb to 6bd7a8b Compare March 7, 2024 13:06

milesgranger marked this pull request as draft March 7, 2024 13:07

milesgranger self-assigned this Mar 7, 2024

milesgranger force-pushed the milesgranger/fix-ci branch from b8fe402 to f2ff34e Compare March 7, 2024 13:32

milesgranger added 10 commits March 7, 2024 14:41

Check UserWarning in test_client.py::test_recreate_error_collection

f527f49

Check UserWarning in test_client.py::test_recreate_task_collection

286903d

ignore UserWarning: dask-expr does not support DataFrameIOFunction pr…

f71ea01

…otocol xref dask/dask-expr#945

xfail test_steal.py::test_blocklist_shuffle_split blocked is empty

6fb111b

xfail test_scheduler.py::test_default_task_duration_splits - split_pr…

e5f70f9

…efix != 1

test_merge_unknown_to_unknown: skip layer checks when dask-expr enabled

5c712a0

xfail test_dataframe_annotations when dask-expr enabled

6cc06a9

test_raise_on_complex_numbers - dask-expr branch

815422c

test_raise_on_sparse_data - dask-expr branch

9f25e6b

test_raise_on_non_string_column_name - dask-expr branch

4daa85c

milesgranger force-pushed the milesgranger/fix-ci branch from f2ff34e to 4daa85c Compare March 7, 2024 13:41

fjetter reviewed Mar 7, 2024

View reviewed changes

distributed/protocol/tests/test_highlevelgraph.py Outdated Show resolved Hide resolved

crusaderky self-assigned this Mar 7, 2024

crusaderky mentioned this pull request Mar 7, 2024

Weigh gilknocker Prometheus metric by duration #8558

Merged

crusaderky mentioned this pull request Mar 7, 2024

Fix scheduler transition error on memory->erred #8549

Merged

2 tasks

hendrikmakait self-requested a review March 7, 2024 14:40

hendrikmakait added 5 commits March 7, 2024 16:30

Don't use dd.shuffle.shuffle

7ed678e

Don't test minimal version for dask-expr in P2P

f6f5930

No worker restrictions

eb53213

Adjust unpack prefix

68d7edf

Restrictions are not implemented

8c908a2

milesgranger added 2 commits March 8, 2024 11:35

xfail test_dataframes

3f93b93

xfail test_dataframe_set_index_sync - passes fine locally...

3d6471f

milesgranger force-pushed the milesgranger/fix-ci branch from 4d756b7 to 3d6471f Compare March 8, 2024 10:35

Fix test_dataframes

cadfe01

milesgranger marked this pull request as ready for review March 8, 2024 11:16

crusaderky added 6 commits March 8, 2024 11:34

test_recreate_error_collection on mindeps-pandas

aff2a8c

test_recreate_task_collection on mindeps-pandas

8dbb385

Review test_merge.py

32062fa

Review test_futures_of_sorted

78a773f

Revert test_dataframe_set_index_sync

3e9545d

Cosmetic

9d90f90

crusaderky reviewed Mar 8, 2024

View reviewed changes

Use dask.bag for test_futures_of_sorted

8ea35f0

crusaderky reviewed Mar 8, 2024

View reviewed changes

Revert test_broken_comm

3240987

crusaderky force-pushed the milesgranger/fix-ci branch from 3ff2bd0 to 3240987 Compare March 8, 2024 14:46

crusaderky and others added 3 commits March 8, 2024 15:13

Review test_crashed_worker_after_shuffle

f5abd39

test_crashed_worker_after_shuffle without Nanny

9ab8ca6

Merge branch 'main' into milesgranger/fix-ci

e974509

hendrikmakait reviewed Mar 8, 2024

View reviewed changes

distributed/shuffle/tests/test_shuffle.py Outdated Show resolved Hide resolved

crusaderky added 3 commits March 8, 2024 15:50

Revert changes about default durations

4e5c4d4

Merge remote-tracking branch 'milesgranger/milesgranger/fix-ci' into …

a2bdc78

…milesgranger/fix-ci

Revert nanny changes in test_crashed_worker_after_shuffle

1ccfad6

crusaderky mentioned this pull request Mar 8, 2024

Mark fast tasks of tasks-based shuffle when dask-expr is enabled #8563

Merged

hendrikmakait approved these changes Mar 8, 2024

View reviewed changes

crusaderky mentioned this pull request Mar 8, 2024

Release 2024.3.0 dask/community#366

Closed

4 tasks

crusaderky approved these changes Mar 8, 2024

View reviewed changes

phofl merged commit e16a7af into dask:main Mar 8, 2024
12 of 35 checks passed

milesgranger deleted the milesgranger/fix-ci branch March 8, 2024 19:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make CI happy again #8560

Make CI happy again #8560

milesgranger commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading

crusaderky Mar 8, 2024 •

edited

Loading

phofl Mar 8, 2024

crusaderky Mar 8, 2024

phofl Mar 8, 2024

phofl Mar 8, 2024

phofl Mar 8, 2024

crusaderky Mar 8, 2024

phofl Mar 8, 2024

crusaderky Mar 8, 2024

crusaderky commented Mar 8, 2024 •

edited

Loading

hendrikmakait left a comment

		if dd._dask_expr_enabled():
		pytest.skip("No split task in dask-expr")

		@@ -1011,6 +1011,7 @@ async def test_balance_with_longer_task(c, s, a, b):
		assert z.key in b.data


		@pytest.mark.xfail(reason="blocked is empty", raises=AssertionError)

Make CI happy again #8560

Make CI happy again #8560

Conversation

milesgranger commented Mar 7, 2024 • edited Loading

github-actions bot commented Mar 7, 2024 • edited Loading

Unit Test Results

crusaderky Mar 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crusaderky commented Mar 8, 2024 • edited Loading

hendrikmakait left a comment

Choose a reason for hiding this comment

milesgranger commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading

crusaderky Mar 8, 2024 •

edited

Loading

crusaderky commented Mar 8, 2024 •

edited

Loading