Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile._f_lineno: handle next_line being None in Python 3.13 #8710

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

AdamWill
Copy link
Contributor

In Python 3.13, it's possible for dis.findlinestarts to return a line number as None. We don't ever want to return None as the line number, so guard against this.

  • Tests added / passed
  • Passes pre-commit run --all-files

In Python 3.13, it's possible for `dis.findlinestarts` to return
a line number as `None`. We don't ever want to return `None` as
the line number, so guard against this.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@AdamWill AdamWill requested a review from fjetter as a code owner June 20, 2024 06:50
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±    0      29 suites  ±0   11h 28m 49s ⏱️ + 1h 23m 23s
 4 061 tests  -     5   3 960 ✅ +   13     97 💤  -   9  4 ❌  - 5 
55 939 runs  +7 597  53 770 ✅ +7 372  2 163 💤 +247  6 ❌  - 5 

For more details on these failures, see this check.

Results for commit a47265f. ± Comparison against base commit aeebb2d.

This pull request removes 13 and adds 8 tests. Note that renamed tests count towards both.
distributed.protocol.tests.test_arrow
distributed.protocol.tests.test_collection
distributed.protocol.tests.test_highlevelgraph
distributed.protocol.tests.test_numpy
distributed.protocol.tests.test_pandas
distributed.shuffle.tests.test_graph
distributed.shuffle.tests.test_merge
distributed.shuffle.tests.test_merge_column_and_index
distributed.shuffle.tests.test_metrics
distributed.shuffle.tests.test_rechunk
…
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[report_args0]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[1]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[True]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[report_args0]

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing all those small issues! If there is something we can help you with, let us know

@fjetter fjetter merged commit 8506165 into dask:main Jun 20, 2024
28 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants