Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event logging functionality into broker #8731

Merged
merged 15 commits into from
Jul 1, 2024

Conversation

hendrikmakait
Copy link
Member

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ± 0      29 suites  ±0   11h 21m 31s ⏱️ +25s
 4 083 tests + 3   3 966 ✅ + 1    112 💤 ±0  5 ❌ +2 
55 230 runs  +42  52 789 ✅ +40  2 434 💤  - 1  7 ❌ +3 

For more details on these failures, see this check.

Results for commit 0422cf5. ± Comparison against base commit 147c505.

This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.
distributed.diagnostics.tests.test_scheduler_plugin ‑ test_log_event_plugin
distributed.diagnostics.tests.test_scheduler_plugin ‑ test_log_event_plugin_multiple_topics
distributed.tests.test_event_logging ‑ test_log_event_e2e
distributed.tests.test_event_logging ‑ test_log_event_plugin
distributed.tests.test_event_logging ‑ test_log_event_plugin_multiple_topics
distributed.tests.test_event_logging ‑ test_log_events
distributed.tests.test_event_logging ‑ test_topic_subscribe_unsubscribe

♻️ This comment has been updated with latest results.


log = [log[-i][1][1] for i in range(1, n + 1) if log[-i][1][0] == "request"]
self.last = current
topic = self.scheduler._broker._topics["stealing"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like hooking deeply into these private attributes but I don't care enough for now to do something about it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even sure if we need this event but let's postpone this decision

@hendrikmakait hendrikmakait marked this pull request as ready for review June 26, 2024 14:09
@hendrikmakait
Copy link
Member Author

Note: Overall, our event logging mechanism is a weird mix of a push and a pull-based messaging architecture. We may want to revisit this, but generally, it works 🤷.

@hendrikmakait hendrikmakait merged commit 63e5108 into dask:main Jul 1, 2024
27 of 34 checks passed
@hendrikmakait hendrikmakait deleted the refactor-log-event-to-broker branch July 1, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants