-
-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor event logging functionality into broker #8731
Refactor event logging functionality into broker #8731
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files ± 0 29 suites ±0 11h 21m 31s ⏱️ +25s For more details on these failures, see this check. Results for commit 0422cf5. ± Comparison against base commit 147c505. This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
|
||
log = [log[-i][1][1] for i in range(1, n + 1) if log[-i][1][0] == "request"] | ||
self.last = current | ||
topic = self.scheduler._broker._topics["stealing"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like hooking deeply into these private attributes but I don't care enough for now to do something about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not even sure if we need this event but let's postpone this decision
Note: Overall, our event logging mechanism is a weird mix of a push and a pull-based messaging architecture. We may want to revisit this, but generally, it works 🤷. |
Closes #xxxx
pre-commit run --all-files