New tests for formats, predicates, tables and utils #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwagner
reviewed
Nov 12, 2022
tests/test_formats.py
Outdated
| fmtc = ds.default_formatter.format_column | ||
|
|
||
| description_list = ["A data scientist is someone who creates programming code and combines it with statistical knowledge to create insights from data."] | ||
| pad = fmtc("Carreers", description_list) |
davidwagner
reviewed
Nov 12, 2022
davidwagner
reviewed
Nov 12, 2022
tests/test_util.py
Outdated
| @@ -78,7 +81,7 @@ def test_minimize_smooth(): | |||
|
|
|||
|
|
|||
| def test_minimize_array(): | |||
| assert _round_eq(2, ds.minimize(lambda x: (x[0]-2)**2, [0], array=True)) | |||
| assert _round_eq(2, ds.minimize(lambda x: (x[0]-2)**2, [0], array=True, log=print)) | |||
There was a problem hiding this comment.
Can you help me understand the purpose of this change?
davidwagner
reviewed
Nov 12, 2022
tests/test_util.py
Outdated
| @@ -96,3 +99,14 @@ def test_proportions_from_distribution(): | |||
| uniform = u.column(1) | |||
| assert len(uniform) == 50 and _round_eq(1, sum(uniform)) | |||
| assert [x in (0, 0.5, 1) for x in ds.sample_proportions(2, ds.make_array(.2, .3, .5))] | |||
|
|
|||
| def test_is_non_string_iterable(): | |||
| class Sequece_Class(collections.abc.Sequence): | |||
davidwagner
reviewed
Nov 12, 2022
tests/test_util.py
Outdated
| def __len__(self): | ||
| return len(self._args) | ||
|
|
||
| assert ds.is_non_string_iterable(Sequece_Class()) == True |
davidwagner
reviewed
Nov 12, 2022
tests/test_util.py
Outdated
| def __len__(self): | ||
| return len(self._args) | ||
|
|
||
| assert ds.is_non_string_iterable(Sequece_Class()) == True |
There was a problem hiding this comment.
Might be useful to test on a list and array as well.
adnanhemani
reviewed
Dec 23, 2022
tests/test_tables.py
Outdated
| @@ -1900,4 +1900,4 @@ def test_read_table(): | |||
| assert isinstance(Table().read_table("tests/us-unemployment.csv"), Table) | |||
| assert isinstance(Table().read_table("tests/us-unemployment-copy"), Table) | |||
| assert isinstance(Table().read_table("tests/us-unemployment.txt"), Table) | |||
| assert isinstance(Table().read_table("https://raw.githubusercontent.com/data-8/textbook/main/assets/data/deflategate.csv"), Table) | |||
| assert isinstance(Table().read_table("https://raw.githubusercontent.com/data-8/textbook/main/assets/data/deflategate.csv"), Table) | |||
There was a problem hiding this comment.
Can we please not remove the extra line at the end?
tests/test_util.py
Outdated
| @@ -78,7 +81,7 @@ def test_minimize_smooth(): | |||
|
|
|||
|
|
|||
| def test_minimize_array(): | |||
| assert _round_eq(2, ds.minimize(lambda x: (x[0]-2)**2, [0], array=True)) | |||
| assert _round_eq(2, ds.minimize(lambda x: (x[0]-2)**2, [0], array=True, log=print)) | |||
|
@davidwagner I've fixed this PR up, please go ahead and re-review when you get some time :) |
davidwagner
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
New tests for the features already developed. Formats and Predicates with 100% coverage.