Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test to check if an empty table is created from records if empty record list #582

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Adds a test to check if an empty table is created from records if empty record list #582

merged 1 commit into from
Feb 13, 2023

Conversation

aad1tya
Copy link
Contributor

@aad1tya aad1tya commented Feb 11, 2023

#476
Table().from_records() should return an empty table.
[*] Wrote test for feature

Changes proposed:
To increase the code coverage I have added a test to check if an empty table is created when
an empty record is passed.

@coveralls
Copy link

Coverage Status

Coverage: 92.739% (+0.04%) from 92.699% when pulling b499ba0 on aad1tya:records-notpresent into 5c814c7 on data-8:master.

Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@adnanhemani adnanhemani merged commit 2ecc6d8 into data-8:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants