Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pulling from private Github repos #3

Merged
merged 1 commit into from
Jan 22, 2016
Merged

Conversation

SamLau95
Copy link
Member

Adds the GITHUB_ORG environment variable which contains an API key
allowing the server to pull private repos from data-8.

Also adds a BASE_URL environment variable which allows the master
branch to be deployed to both ds8 and data8.

Resolves data-8/connector-instructors#9 .

Adds the `GITHUB_ORG` environment variable which contains an API key
allowing the server to pull private repos from data-8.

Also adds a `BASE_URL` environment variable which allows the master
branch to be deployed to both ds8 and data8.
SamLau95 added a commit that referenced this pull request Jan 22, 2016
Enable pulling from private Github repos
@SamLau95 SamLau95 merged commit 30a44c8 into master Jan 22, 2016
@SamLau95 SamLau95 deleted the private-repos branch January 22, 2016 03:48
@deculler
Copy link

Sam,
I'm trying to pull together a little example for this morning's connector
meeting. What's require to make interact link work for an arbitrary public
link?

Not having a convenient repo within data8 I set up a public personal repo.
https://github.com/deculler/ds-connect
That gave me a chance to set up a nice clean gh-pages.

My test is to put the interact blank link in the index.html in the gh-pages
branch.

David E. Culler
Friesen Professor of Computer Science
Electrical Engineering and Computer Sciences
University of California, Berkeley

On Thu, Jan 21, 2016 at 7:47 PM, Sam Lau notifications@github.com wrote:

Adds the GITHUB_ORG environment variable which contains an API key
allowing the server to pull private repos from data-8.

Also adds a BASE_URL environment variable which allows the master

branch to be deployed to both ds8 and data8.

You can view, comment on, or merge this pull request online at:

#3
Commit Summary

  • Enable pulling from private Github repos

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#3.

@SamLau95
Copy link
Member Author

Hey David, sorry for the late reply; right now the interact server is hardcoded to pull from data-8 repos.

I forked your repo to https://github.com/data-8/ds-connect so you can make links work with that for today since we don't have much time.

@SamLau95
Copy link
Member Author

Eg. using links like

https://data8.berkeley.edu/hub/interact?repo=ds-connect&path=README.md

@deculler
Copy link

Ahh, while sitting class I got John to create cs-connector. All of one
mind. Two issues.

#1 These links all open up the clone of the repo rather than the file at
the end of the path. Your example does this too.

#2 I discovered going through this with the connector instructors that
getting the very first notebook into their repo (without using the obvious
command line tools) was a pain. Once we fix the path problem, we can
create an initial page in all the gh-pages branches that will eliminate
that problem.

David E. Culler
Friesen Professor of Computer Science
Electrical Engineering and Computer Sciences
University of California, Berkeley

On Fri, Jan 22, 2016 at 11:03 AM, Sam Lau notifications@github.com wrote:

Hey David, sorry for the late reply; right now the interact server is
hardcoded to pull from data-8 repos.

I forked your repo to https://github.com/data-8/ds-connect so you can
make links work with that for today since we don't have much time.


Reply to this email directly or view it on GitHub
#3 (comment).

@deculler
Copy link

This one give me the repo directory, not the file. Is that what it does
for you?
On Jan 22, 2016 11:03 AM, "Sam Lau" notifications@github.com wrote:

Eg. using links like

https://data8.berkeley.edu/hub/interact?repo=ds-connect&path=README.md


Reply to this email directly or view it on GitHub
#3 (comment).

@SamLau95
Copy link
Member Author

Yup, for now. See data-8/connector-instructors#16

SamLau95 added a commit that referenced this pull request Jan 24, 2016
This implements issue #16:

Right now, hitting a url like:

    https://data8.berkeley.edu/hub/interact?repo=data8assets&path=labs/lab01

Results in the student being redirected to the root of the repo:
`data8assets`.

Instead, it'd be more convenient if the student were redirected to the
path given in the URL: `data8assets/labs/lab01`.

Since you can specify multiple values for `path` in the URL, eg.

    https://data8.berkeley.edu/hub/interact?repo=data8assets&path=labs/lab01&path=labs/lab01/lab01.ipynb

The last path will be chosen to redirect to. In the above example, the
student will be sent directly to the notebook.

See the discussion in #15 and #3 .

Resolves #16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants