Only require axis to be negative in vecdot and cross #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nonnegative axes and negative axes less than the smaller of the two arrays are unspecified. This is because it is ambiguous in these cases whether the dimension should refer to the axis before or after broadcasting. Preciously, the spec stated it should refer to the dimension before broadcasting, but this deviates from NumPy gufunc behavior, and results in ambiguous and confusing situations, where, for instance, the result of a the function is different when the inputs are manually broadcasted together. Also clean up some of the cross text a little bit since the computed dimension must be exactly size 3. Fixes data-apis#724 Fixes data-apis#617 See the discussion in those issues for more details.
This was referenced Feb 2, 2024
asmeurer
added a commit
to asmeurer/array-api-tests
that referenced
this pull request
Feb 3, 2024
asmeurer
added a commit
to asmeurer/array-api-tests
that referenced
this pull request
Feb 3, 2024
This also updates it to only test axes from [min(x1.ndim, x2.ndim), -1], as per data-apis/array-api#740
This was referenced Feb 3, 2024
|
We could also allow nonnegative axis when the two input arrays have the same number of dimensions. In that case, there is no ambiguity for something like |
|
@kgryte could you remind me if this will be part of v2023? |
cr313
added a commit
to cr313/test-array-api
that referenced
this pull request
Apr 19, 2024
cr313
added a commit
to cr313/test-array-api
that referenced
this pull request
Apr 19, 2024
This also updates it to only test axes from [min(x1.ndim, x2.ndim), -1], as per data-apis/array-api#740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonnegative axes and negative axes less than the smaller of the two arrays are unspecified.
This is because it is ambiguous in these cases whether the dimension should refer to the axis before or after broadcasting. Previously, the spec stated it should refer to the dimension before broadcasting, but this deviates from NumPy gufunc behavior, and results in ambiguous and confusing situations, where, for instance, the result of a the function is different when the inputs are manually broadcasted together.
Also clean up some of the cross text a little bit since the computed dimension must be exactly size 3.
Fixes #724
Fixes #617
See the discussion in those issues for more details.
I don't think this should be backported, since my vecdot implementation in np.array_api and array-api-compat already followed the spec behavior here, and will need to be updated.