Add search (Autocomplete) in environment/group dropdown in create/import forms #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8c091ec.
dlpzx
changed the title
noah-paige
reviewed
Jun 19, 2024
noah-paige
reviewed
Jun 19, 2024
noah-paige
reviewed
Jun 19, 2024
dlpzx
force-pushed
the
feat/search-env-dropdown-generic
branch
from
95a8512
to
2298fa7
Compare
noah-paige
reviewed
Jun 24, 2024
noah-paige
reviewed
Jun 24, 2024
noah-paige
reviewed
Jun 24, 2024
noah-paige
reviewed
Jun 24, 2024
noah-paige
reviewed
Jun 24, 2024
Comment on lines
+538
to
+554
| <TextField | ||
| error={Boolean( | ||
| touched.SamlAdminGroupName && | ||
| errors.SamlAdminGroupName | ||
| )} | ||
| helperText={ | ||
| touched.SamlAdminGroupName && | ||
| errors.SamlAdminGroupName | ||
| } | ||
| fullWidth | ||
| disabled | ||
| label="Team" | ||
| value="No teams found for this environment" | ||
| variant="outlined" | ||
| /> | ||
| )} | ||
| </Box> |
There was a problem hiding this comment.
nit: This TextField component (and all other ones for when groupOptions is empty) has a different sizing then the other TextFields on the form and the other TextField when groupOptions are present
There was a problem hiding this comment.
I noticed, not very sure why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Autocomplete for environments and teams in the following frontend views as requested in 1012.
This PR introduces a 2 new Shared frontend components: EnvironmentTeamDropdown and EnvironmentTeamDatasetsDropdown. They are generic formik fields that can be reused in Formik forms in several modules. Some creation forms include custom parameters that are fetched alongside the environments and teams (e.g. Notebooks sets VPCs). For those cases, we implement the Autocomplete logic in the view itself
Pipelines in a separate PR
In all forms we use
SamlAdminGroupNameinstead ofSamlGroupNameas a standard that allows us to use Shared componentsRelates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.