-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search (Autocomplete) in environment/group dropdown in Share request modal #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested locally:
Recording of the tests: |
…eat/search-env-dropdown # Conflicts: # frontend/src/modules/Catalog/components/RequestAccessModal.js
This was referenced Jun 18, 2024
noah-paige
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - approving
tested locally as well!
dlpzx
added a commit
that referenced
this pull request
Jun 25, 2024
…ort forms (#1347) ### Feature or Bugfix - Feature ### Detail Autocomplete for environments and teams in the following frontend views as requested in 1012. This PR introduces a 2 new Shared frontend components: EnvironmentTeamDropdown and EnvironmentTeamDatasetsDropdown. They are generic formik fields that can be reused in Formik forms in several modules. Some creation forms include custom parameters that are fetched alongside the environments and teams (e.g. Notebooks sets VPCs). For those cases, we implement the Autocomplete logic in the view itself - [X] DashboardImportForm.js - using EnvironmentTeamDropdown - [X] MLStudioCreateForm.js - using EnvironmentTeamDropdown - [X] NotebookCreateForm.js - custom - [X] OmicsRunCreateForm.js - using EnvironmentTeamDatasetsDropdown - [X] DatasetCreateForm.js - custom - [X] DatasetImportForm.js - custom Pipelines in a separate PR In all forms we use `SamlAdminGroupName` instead of `SamlGroupName` as a standard that allows us to use Shared components ### Relates - #1335 - #1012 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
In the following view, instead of using a fixed list in the environment, team and consumption roles dropdowns; this PR introduces search capabilities as requested in #1012. There are still many other dropdowns to change, where we will be able to extract a common frontend component. This one however, is a bit particular so I implemented it separately.
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A
. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
eval
or similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.