Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added node v. 16 to pipeline buildspec #49

Merged
merged 1 commit into from
Jun 15, 2022
Merged

fix: added node v. 16 to pipeline buildspec #49

merged 1 commit into from
Jun 15, 2022

Conversation

wolanlu
Copy link
Contributor

@wolanlu wolanlu commented Jun 14, 2022

fix:

  • added node v. 16 to pipeline buildspec
  • skipping manual approval for pipelines that have only one step

Feature or Bugfix

  • Bugfix

Detail

  • buildspec does not specify node version which default to node v. 12 which is already not supported by cdk. This ends with pipeline not building
  • it a minor but when specifying pipeline stages user can choose to have only one stage. This one stage pipeline should not have a manual approval step in the end regardless the name of the stage.

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx
Copy link
Contributor

dlpzx commented Jun 15, 2022

thank you for your contribution :)

@dlpzx dlpzx merged commit 29fb18d into data-dot-all:main Jun 15, 2022
@wolanlu wolanlu deleted the fix/manual-step-on-one-step-pipeline branch June 23, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolanlu @dlpzx