CARDS-2513: Status flags for subjects #1754
Conversation
| @@ -564,6 +567,10 @@ const questionnaireStyle = theme => ({ | |||
| marginBottom: theme.spacing(1), | |||
| marginRight: theme.spacing(1), | |||
| }, | |||
| subjectChartChip: { | |||
There was a problem hiding this comment.
Can't we reuse the subjectChip className from line 566? The two have similar names, purposes and styles, we should merge them.
There was a problem hiding this comment.
Oh, this is not nice. All these classes shouldn't be "something Chip", since that is a technical detail about the implementation, they should have meaningful semantic names. Maybe replace Chip with StatusFlag or even Flag. And differentiate between classes that say what kind of flag it is, and classes that say where it appears, e.g. INCOMPLETEFlag and flagInSubjectChart. But is the second case actually needed? I don't know how styles and style classes work here, but in pure CSS you could just say .subjectChart .DefaultFlag.
Just nitpicking, this isn't related to this PR.
There was a problem hiding this comment.
And to answer the question, I don't think it can be reused, one is about chips about the subject that you're looking at itself, one is about chips about other related items inside the subject chart.
There was a problem hiding this comment.
I've updated the names to be a little clearer what they are for. Can't easily reuse subjectChip as they the chips don't look vertically centered with the same bottom margin
modules/data-entry/src/main/frontend/src/questionnaire/Subject.jsx
Outdated
Show resolved
Hide resolved
|
Would this look any better? |
It's complicated... the forms under each subject are displayed in a table, so having kind of layout will be a tad difficult in most cases |
|
Layout has been updated (see the screenshot in the first comment for an example). |
modules/data-entry/src/main/frontend/src/questionnaire/QuestionnaireStyle.jsx
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/questionnaire/Subject.jsx
Outdated
Show resolved
Hide resolved
modules/data-entry/src/main/frontend/src/questionnaire/Subject.jsx
Outdated
Show resolved
Hide resolved
Remove extra spaces in style sheet
Adjust css class names and improve html layout
Fix some some status flags still using chip naming scheme
Add status flags to subjects which are displayed in the subject chart and subject header