Skip build in bash if azure isn't playing along #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilko77
reviewed
Feb 26, 2020
| @@ -88,7 +88,7 @@ stages: | |||
| dependsOn: HashBaseDependencies | |||
| imageName: data61/anonlink-app | |||
| # this part is still todo automated | |||
| dockerBuildArgs: "--build-arg VERSION=02a973ce02c96d24376c5770c0426ccb0958a0d59136a4f2fc11c8666c43062a" | |||
| dockerBuildArgs: "--build-arg VERSION=ed0be6ee130ec505b2a65af26ba570e1033ffb7e0cc6b27b6a8520df94f65d20" | |||
There was a problem hiding this comment.
this is really annoying. When we change the base image requirements, although a new version gets build, it will not be tested. We already had a non-functioning base image. We really need to find a way to test the new base images straight away.
wilko77
approved these changes
Feb 28, 2020
|
Agree it could be nicer if Azure was a bit easier to use. Have added the need to automate using and testing the latest base image to the backlog. |
|
Oh that is annoying, I set the merge target as |
This was referenced Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition in azure didn't seem to take effect so we now check whether to skip the expensive image building in bash. I've tried various combinations of using strings and booleans in the main azure script and docker build template and cannot make Azure Pipelines do what I expect.
I updated the base digest too