Liberating pipeline #365
Liberating pipeline #365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 16 16
Lines 792 792
=======================================
Hits 749 749
Misses 43 43 |
Only one way to find out...
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -35,8 +35,9 @@ steps: | |||
| opSysFlag=$(echo ${{ parameters.operatingSystem }} | sed 's/[[:punct:]]//g' | tr '[:upper:]' '[:lower:]' | head -c30) | |||
| pyVFlag=$(echo python${{ parameters.pythonVersion }} | sed 's/[[:punct:]]//g' | tr '[:upper:]' '[:lower:]' | head -c30) | |||
| echo "codecov flags: $opSysFlag,$pyVFlag" | |||
| python -m codecov --token $(CODECOV_TOKEN) \ | |||
| --file coverage.xml \ | |||
| bash <(curl -s https://codecov.io/bash) \ | |||
There was a problem hiding this comment.
no need for token anymore?
There was a problem hiding this comment.
the codecov tool reads the token from the environment variable. So no need to specify it here. -> Less clutter. :)
| trigger: | ||
| branches: | ||
| include: | ||
| - '*' |
There was a problem hiding this comment.
why do you delete this section? The pipeline will no longer be triggered by PRs?
There was a problem hiding this comment.
It's actually the opposite. The pr: none bit prevented the pipeline to be triggered by a PR. However, we want every PR to trigger the tests. External PRs won't have access to the secrets, thus this is fine.
By removing all of this, we get the default behavior, which is run for every PR.
We had two problems with PR from external repos:
I changed the pipeline to: