Add github action to build and publish wheels #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardbyte
force-pushed
the
feature/cibuildwheel-with-github-action
branch
from
86efe67
to
9dc6c8f
Compare
Codecov Report
@@ Coverage Diff @@
## main #517 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 16 16
Lines 797 797
=======================================
Hits 751 751
Misses 46 46 |
wilko77
approved these changes
Mar 7, 2022
.github/workflows/build_wheels.yml
Outdated
| @@ -0,0 +1,54 @@ | |||
| name: Build and upload to PyPI | |||
|
|
|||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
do we really need to do this on every push? It's about 30 minutes of building wheels and we use the resources for free.
I'm leaning towards building for every pull request and release.
Did you know that github action can be triggered on release?
There was a problem hiding this comment.
Oh I didn't know that about releases - will add.
Agree, we could be more conscientious of the generous free resources github actions is allowing us to use - will change to run on PR and release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Github Actions workflow to build and optionally publish binary artifacts for major operating systems and Python versions using
cibuildwheel.The action very much follows the example from the cibuildwheel docs - https://cibuildwheel.readthedocs.io/en/stable/setup/#github-actions
The publish step only runs when it sees a tag that starts with
v- then this step will publish all the artifacts to pypi. Note there is already a repository secret in this github repo with a tightly scoped PYPI api token that is allowed to upload packages for just anonlink.You can see the working Github Action here.
I suggest removing the azure build wheel steps - I can do that in this PR if you like?