Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI nightlies on our UC workspaces #1225

Merged
merged 3 commits into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions internal/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -484,8 +484,9 @@ func TemporaryRepo(t *testing.T, w *databricks.WorkspaceClient) string {
func GetNodeTypeId(env string) string {
if env == "gcp" {
return "n1-standard-4"
} else if env == "aws" {
return "i3.xlarge"
} else if env == "azure" {
return "Standard_DS4_v2"
}
return "Standard_DS4_v2"
// We default to AWS because our "aws-prod-ucws" test environment has CLOUD_ENV set to "ucws"
shreyas-goenka marked this conversation as resolved.
Show resolved Hide resolved
return "i3.xlarge"
}
3 changes: 3 additions & 0 deletions internal/testutil/cloud.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ func GetCloud(t *testing.T) Cloud {
return Azure
case "gcp":
return GCP
// CLOUD_ENV is set to "ucws" in the "aws-prod-ucws" test environment
case "ucws":
return AWS
default:
t.Fatalf("Unknown cloud environment: %s", env)
}
Expand Down
Loading