Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI nightlies on our UC workspaces #1225

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fix CLI nightlies on our UC workspaces #1225

merged 3 commits into from
Feb 21, 2024

Conversation

shreyas-goenka
Copy link
Contributor

This PR fixes some test helper functions so that they work properly on our test environments for AWS and Azure UC workspaces.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ffae10d) 51.94% compared to head (22623ab) 52.60%.
Report is 9 commits behind head on main.

Files Patch % Lines
internal/helpers.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
+ Coverage   51.94%   52.60%   +0.65%     
==========================================
  Files         301      308       +7     
  Lines       16804    17223     +419     
==========================================
+ Hits         8729     9060     +331     
- Misses       7436     7495      +59     
- Partials      639      668      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyas-goenka shreyas-goenka changed the title Fix CLI nightlies to run on UC workspaces Fix CLI nightlies on our UC workspaces Feb 20, 2024
internal/helpers.go Outdated Show resolved Hide resolved
@shreyas-goenka shreyas-goenka added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 4ac1c16 Feb 21, 2024
4 checks passed
@shreyas-goenka shreyas-goenka deleted the uc-on-cli branch February 21, 2024 13:13
andrewnester added a commit that referenced this pull request Feb 23, 2024
CLI:
 * Improved error message when no .databrickscfg ([#1223](#1223)).
 * Use Go SDK Iterators when listing resources with the CLI ([#1202](#1202)).

Bundles:
 * Only set ComputeID value when `--compute-id` flag provided ([#1229](#1229)).
 * Add correct tag value for models in dev mode ([#1230](#1230)).
 * Upgrade Terraform provider to 1.37.0 ([#1235](#1235)).

Internal:
 * Fix CLI nightlies on our UC workspaces ([#1225](#1225)).
 * Handle alias types for map keys in toTyped conversion ([#1232](#1232)).
@andrewnester andrewnester mentioned this pull request Feb 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
CLI:
* Improved error message when no .databrickscfg
([#1223](#1223)).
* Use Go SDK Iterators when listing resources with the CLI
([#1202](#1202)).

Bundles:
* Only set ComputeID value when `--compute-id` flag provided
([#1229](#1229)).
* Add correct tag value for models in dev mode
([#1230](#1230)).
* Upgrade Terraform provider to 1.37.0
([#1235](#1235)).

Internal:
* Fix CLI nightlies on our UC workspaces
([#1225](#1225)).
* Handle alias types for map keys in toTyped conversion
([#1232](#1232)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants