-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CLI nightlies on our UC workspaces #1225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
+ Coverage 51.94% 52.60% +0.65%
==========================================
Files 301 308 +7
Lines 16804 17223 +419
==========================================
+ Hits 8729 9060 +331
- Misses 7436 7495 +59
- Partials 639 668 +29 ☔ View full report in Codecov by Sentry. |
shreyas-goenka
changed the title
Fix CLI nightlies to run on UC workspaces
Fix CLI nightlies on our UC workspaces
Feb 20, 2024
andrewnester
approved these changes
Feb 21, 2024
andrewnester
added a commit
that referenced
this pull request
Feb 23, 2024
CLI: * Improved error message when no .databrickscfg ([#1223](#1223)). * Use Go SDK Iterators when listing resources with the CLI ([#1202](#1202)). Bundles: * Only set ComputeID value when `--compute-id` flag provided ([#1229](#1229)). * Add correct tag value for models in dev mode ([#1230](#1230)). * Upgrade Terraform provider to 1.37.0 ([#1235](#1235)). Internal: * Fix CLI nightlies on our UC workspaces ([#1225](#1225)). * Handle alias types for map keys in toTyped conversion ([#1232](#1232)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
CLI: * Improved error message when no .databrickscfg ([#1223](#1223)). * Use Go SDK Iterators when listing resources with the CLI ([#1202](#1202)). Bundles: * Only set ComputeID value when `--compute-id` flag provided ([#1229](#1229)). * Add correct tag value for models in dev mode ([#1230](#1230)). * Upgrade Terraform provider to 1.37.0 ([#1235](#1235)). Internal: * Fix CLI nightlies on our UC workspaces ([#1225](#1225)). * Handle alias types for map keys in toTyped conversion ([#1232](#1232)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some test helper functions so that they work properly on our test environments for AWS and Azure UC workspaces.