Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle alias types for map keys in toTyped conversion #1232

Merged
merged 1 commit into from Feb 22, 2024

Conversation

andrewnester
Copy link
Contributor

Changes

Handle alias types for map keys in toTyped conversion

Tests

Added an unit test

@andrewnester andrewnester added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit f69b707 Feb 22, 2024
4 checks passed
@andrewnester andrewnester deleted the fix/script-hook branch February 22, 2024 15:26
andrewnester added a commit that referenced this pull request Feb 23, 2024
CLI:
 * Improved error message when no .databrickscfg ([#1223](#1223)).
 * Use Go SDK Iterators when listing resources with the CLI ([#1202](#1202)).

Bundles:
 * Only set ComputeID value when `--compute-id` flag provided ([#1229](#1229)).
 * Add correct tag value for models in dev mode ([#1230](#1230)).
 * Upgrade Terraform provider to 1.37.0 ([#1235](#1235)).

Internal:
 * Fix CLI nightlies on our UC workspaces ([#1225](#1225)).
 * Handle alias types for map keys in toTyped conversion ([#1232](#1232)).
@andrewnester andrewnester mentioned this pull request Feb 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
CLI:
* Improved error message when no .databrickscfg
([#1223](#1223)).
* Use Go SDK Iterators when listing resources with the CLI
([#1202](#1202)).

Bundles:
* Only set ComputeID value when `--compute-id` flag provided
([#1229](#1229)).
* Add correct tag value for models in dev mode
([#1230](#1230)).
* Upgrade Terraform provider to 1.37.0
([#1235](#1235)).

Internal:
* Fix CLI nightlies on our UC workspaces
([#1225](#1225)).
* Handle alias types for map keys in toTyped conversion
([#1232](#1232)).
@pietern
Copy link
Contributor

pietern commented Feb 26, 2024

@andrewnester Nice! Where did this issue surface?

@andrewnester
Copy link
Contributor Author

@pietern lifecycle scripts (preinit, predeploy and etc.) failed with panic. Added a regression test here #1237

github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants