Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix summary command when internal terraform config doesn't exist #1242

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix summary command when internal terraform config doesn't exist #1242

merged 2 commits into from
Mar 1, 2024

Conversation

ilia-db
Copy link
Contributor

@ilia-db ilia-db commented Feb 28, 2024

Check if bundle.tf.json doesn't exist and create it before executing terraform init (inside terraform.Load)

Fixes a problem when during terraform.Load it fails with:

Error: Failed to load plugin schemas

Error while loading schemas for plugin components: Failed to obtain provider
schema: Could not load the schema for provider
registry.terraform.io/databricks/databricks: failed to instantiate provider
"registry.terraform.io/databricks/databricks" to obtain schema: unavailable
provider "registry.terraform.io/databricks/databricks"..

@ilia-db
Fix summary command when .bundle dir doesn't have bundle.tf.json
351376e 
Check if bundle.tf.json doesn't exist and create it before executing terraform.Load
@ilia-db
Use better names
8aed180
@ilia-db ilia-db changed the title Fix summary command when .bundle dir doesn't have bundle.tf.json Fix summary command when internal terraform config doesn't exist Feb 28, 2024
@ilia-db ilia-db added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit d12f88e Mar 1, 2024
4 checks passed
@ilia-db ilia-db deleted the fix-terraform-initialization-for-summary branch March 1, 2024 08:31
pietern added a commit that referenced this pull request Mar 6, 2024
@pietern
Release v0.215.0
0cd6c59 
CLI:
* The SDK update fixes `fs cp` calls timing out when copying large files.

Bundles:
* Fix summary command when internal Terraform config doesn't exist ([#1242](#1242)).
* Configure cobra.NoArgs for bundle commands where applicable ([#1250](#1250)).
* Fixed building Python artifacts on Windows with WSL ([#1249](#1249)).
* Add `--validate-only` flag to run validate-only pipeline update ([#1251](#1251)).
* Only transform wheel libraries when using trampoline ([#1248](#1248)).
* Return `application_id` for service principal lookups ([#1245](#1245)).
* Support relative paths in artifact files source section and always upload all artifact files ([#1247](#1247)).
* Fix DBConnect support in VS Code ([#1253](#1253)).

Internal:
* Added test to verify scripts.Execute mutator works correctly ([#1237](#1237)).

API Changes:
* Added `databricks permission-migration` command group.
* Updated nesting of the `databricks settings` and `databricks account settings commands`
* Changed `databricks vector-search-endpoints delete-endpoint` command with new required argument order.
* Changed `databricks vector-search-indexes create-index` command with new required argument order.
* Changed `databricks vector-search-indexes delete-data-vector-index` command with new required argument order.
* Changed `databricks vector-search-indexes upsert-data-vector-index` command with new required argument order.

OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04)

Dependency updates:
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 ([#1252](#1252)).
* Update Go SDK to v0.34.0 ([#1256](#1256)).
@pietern pietern mentioned this pull request Mar 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2024
@pietern
Release v0.215.0 (#1257)
a467d01 
CLI:
* The SDK update fixes `fs cp` calls timing out when copying large
files.

Bundles:
* Fix summary command when internal Terraform config doesn't exist
([#1242](#1242)).
* Configure cobra.NoArgs for bundle commands where applicable
([#1250](#1250)).
* Fixed building Python artifacts on Windows with WSL
([#1249](#1249)).
* Add `--validate-only` flag to run validate-only pipeline update
([#1251](#1251)).
* Only transform wheel libraries when using trampoline
([#1248](#1248)).
* Return `application_id` for service principal lookups
([#1245](#1245)).
* Support relative paths in artifact files source section and always
upload all artifact files
([#1247](#1247)).
* Fix DBConnect support in VS Code
([#1253](#1253)).

Internal:
* Added test to verify scripts.Execute mutator works correctly
([#1237](#1237)).

API Changes:
* Added `databricks permission-migration` command group.
* Updated nesting of the `databricks settings` and `databricks account
settings commands`
* Changed `databricks vector-search-endpoints delete-endpoint` command
with new required argument order.
* Changed `databricks vector-search-indexes create-index` command with
new required argument order.
* Changed `databricks vector-search-indexes delete-data-vector-index`
command with new required argument order.
* Changed `databricks vector-search-indexes upsert-data-vector-index`
command with new required argument order.

OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04)

Dependency updates:
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0
([#1252](#1252)).
* Update Go SDK to v0.34.0
([#1256](#1256)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewnester andrewnester andrewnester approved these changes

@kartikgupta-db kartikgupta-db kartikgupta-db approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilia-db @andrewnester @kartikgupta-db