Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative paths in artifact files source section and always upload all artifact files #1247

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

andrewnester
Copy link
Contributor

Support relative paths in artifact files source section and always upload all artifact files

Fixes #1156

Tests

Added unit tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 51.92%. Comparing base (d12f88e) to head (d836b3f).

Files Patch % Lines
bundle/artifacts/artifacts.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1247      +/-   ##
==========================================
- Coverage   52.50%   51.92%   -0.58%     
==========================================
  Files         308      314       +6     
  Lines       17594    17840     +246     
==========================================
+ Hits         9238     9264      +26     
- Misses       7662     7879     +217     
- Partials      694      697       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bundle/artifacts/upload.go Outdated Show resolved Hide resolved
bundle/artifacts/upload.go Outdated Show resolved Hide resolved
@andrewnester andrewnester added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit ecf9c52 Mar 4, 2024
4 checks passed
@andrewnester andrewnester deleted the fix/improve-jar-upload branch March 4, 2024 20:35
pietern added a commit that referenced this pull request Mar 6, 2024
CLI:
* The SDK update fixes `fs cp` calls timing out when copying large files.

Bundles:
* Fix summary command when internal Terraform config doesn't exist ([#1242](#1242)).
* Configure cobra.NoArgs for bundle commands where applicable ([#1250](#1250)).
* Fixed building Python artifacts on Windows with WSL ([#1249](#1249)).
* Add `--validate-only` flag to run validate-only pipeline update ([#1251](#1251)).
* Only transform wheel libraries when using trampoline ([#1248](#1248)).
* Return `application_id` for service principal lookups ([#1245](#1245)).
* Support relative paths in artifact files source section and always upload all artifact files ([#1247](#1247)).
* Fix DBConnect support in VS Code ([#1253](#1253)).

Internal:
* Added test to verify scripts.Execute mutator works correctly ([#1237](#1237)).

API Changes:
* Added `databricks permission-migration` command group.
* Updated nesting of the `databricks settings` and `databricks account settings commands`
* Changed `databricks vector-search-endpoints delete-endpoint` command with new required argument order.
* Changed `databricks vector-search-indexes create-index` command with new required argument order.
* Changed `databricks vector-search-indexes delete-data-vector-index` command with new required argument order.
* Changed `databricks vector-search-indexes upsert-data-vector-index` command with new required argument order.

OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04)

Dependency updates:
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 ([#1252](#1252)).
* Update Go SDK to v0.34.0 ([#1256](#1256)).
@pietern pietern mentioned this pull request Mar 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2024
CLI:
* The SDK update fixes `fs cp` calls timing out when copying large
files.

Bundles:
* Fix summary command when internal Terraform config doesn't exist
([#1242](#1242)).
* Configure cobra.NoArgs for bundle commands where applicable
([#1250](#1250)).
* Fixed building Python artifacts on Windows with WSL
([#1249](#1249)).
* Add `--validate-only` flag to run validate-only pipeline update
([#1251](#1251)).
* Only transform wheel libraries when using trampoline
([#1248](#1248)).
* Return `application_id` for service principal lookups
([#1245](#1245)).
* Support relative paths in artifact files source section and always
upload all artifact files
([#1247](#1247)).
* Fix DBConnect support in VS Code
([#1253](#1253)).

Internal:
* Added test to verify scripts.Execute mutator works correctly
([#1237](#1237)).

API Changes:
* Added `databricks permission-migration` command group.
* Updated nesting of the `databricks settings` and `databricks account
settings commands`
* Changed `databricks vector-search-endpoints delete-endpoint` command
with new required argument order.
* Changed `databricks vector-search-indexes create-index` command with
new required argument order.
* Changed `databricks vector-search-indexes delete-data-vector-index`
command with new required argument order.
* Changed `databricks vector-search-indexes upsert-data-vector-index`
command with new required argument order.

OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04)

Dependency updates:
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0
([#1252](#1252)).
* Update Go SDK to v0.34.0
([#1256](#1256)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifacts - Jar artifact file source requires absolute path
3 participants