Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly transform libraries in for_each_task block #1340

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Correctly transform libraries in for_each_task block #1340

merged 1 commit into from
Apr 5, 2024

Conversation

andrewnester
Copy link
Contributor

Changes

Now DABs correctly transforms and deploys libraries in for_each_task block

tasks:
  - task_key: my_loop
     for_each_task:
       inputs: "[1,2,3]"
         task:
           task_key: my_loop_iteration 
           libraries:
             - pypi:
                  package: my_package

Tests

Added regression test

@andrewnester andrewnester added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 77ff994 Apr 5, 2024
5 checks passed
@andrewnester andrewnester deleted the fix-for-each-libs branch April 5, 2024 15:58
andrewnester added a commit that referenced this pull request Apr 10, 2024
@andrewnester
Release v0.217.1
33a763c 
CLI:
 * Don't attempt auth in `auth profiles --skip-validate` ([#1282](#1282)).
 * Fixed typo in error template for auth describe ([#1341](#1341)).

Bundles:
 * Correctly transform libraries in for_each_task block ([#1340](#1340)).
 * Do not emit warning on YAML anchor blocks ([#1354](#1354)).
 * Fixed pre-init script order ([#1348](#1348)).
 * Execute preinit after entry point to make sure scripts are loaded ([#1351](#1351)).

Dependency updates:
 * Bump internal terraform provider version to `1.39` ([#1339](#1339)).
 * Bump golang.org/x/term from 0.18.0 to 0.19.0 ([#1343](#1343)).
 * Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4 ([#1344](#1344)).
 * Bump golang.org/x/mod from 0.16.0 to 0.17.0 ([#1345](#1345)).
 * Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 ([#1347](#1347)).
 * Bump golang.org/x/sync from 0.6.0 to 0.7.0 ([#1346](#1346)).
@andrewnester andrewnester mentioned this pull request Apr 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 10, 2024
@andrewnester
Release v0.217.1 (#1355)
9e1738d 
CLI:
* Don't attempt auth in `auth profiles --skip-validate`
([#1282](#1282)).
* Fixed typo in error template for auth describe
([#1341](#1341)).

Bundles:
* Correctly transform libraries in for_each_task block
([#1340](#1340)).
* Do not emit warning on YAML anchor blocks
([#1354](#1354)).
* Fixed pre-init script order
([#1348](#1348)).
* Execute preinit after entry point to make sure scripts are loaded
([#1351](#1351)).


Dependency updates:
* Bump internal terraform provider version to `1.39`
([#1339](#1339)).
* Bump golang.org/x/term from 0.18.0 to 0.19.0
([#1343](#1343)).
* Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4
([#1344](#1344)).
* Bump golang.org/x/mod from 0.16.0 to 0.17.0
([#1345](#1345)).
* Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0
([#1347](#1347)).
* Bump golang.org/x/sync from 0.6.0 to 0.7.0
([#1346](#1346)).
@andrewnester andrewnester mentioned this pull request Apr 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 10, 2024
@andrewnester
Release v0.217.1 (#1356)
4529b1a 
CLI:
* Don't attempt auth in `auth profiles --skip-validate`
([#1282](#1282)).
* Fixed typo in error template for auth describe
([#1341](#1341)).

Bundles:
* Correctly transform libraries in for_each_task block
([#1340](#1340)).
* Do not emit warning on YAML anchor blocks
([#1354](#1354)).
* Fixed pre-init script order
([#1348](#1348)).
* Execute preinit after entry point to make sure scripts are loaded
([#1351](#1351)).

Dependency updates:
* Bump internal terraform provider version to `1.39`
([#1339](#1339)).
* Bump golang.org/x/term from 0.18.0 to 0.19.0
([#1343](#1343)).
* Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4
([#1344](#1344)).
* Bump golang.org/x/mod from 0.16.0 to 0.17.0
([#1345](#1345)).
* Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0
([#1347](#1347)).
* Bump golang.org/x/sync from 0.6.0 to 0.7.0
([#1346](#1346)).

## Changes
<!-- Summary of your changes that are easy to understand -->

## Tests
<!-- How is this tested? -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-goenka shreyas-goenka shreyas-goenka approved these changes

@pietern pietern Awaiting requested review from pietern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewnester @shreyas-goenka