Do not emit warning on YAML anchor blocks #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
approved these changes
Apr 10, 2024
andrewnester
added a commit
that referenced
this pull request
Apr 10, 2024
CLI: * Don't attempt auth in `auth profiles --skip-validate` ([#1282](#1282)). * Fixed typo in error template for auth describe ([#1341](#1341)). Bundles: * Correctly transform libraries in for_each_task block ([#1340](#1340)). * Do not emit warning on YAML anchor blocks ([#1354](#1354)). * Fixed pre-init script order ([#1348](#1348)). * Execute preinit after entry point to make sure scripts are loaded ([#1351](#1351)). Dependency updates: * Bump internal terraform provider version to `1.39` ([#1339](#1339)). * Bump golang.org/x/term from 0.18.0 to 0.19.0 ([#1343](#1343)). * Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4 ([#1344](#1344)). * Bump golang.org/x/mod from 0.16.0 to 0.17.0 ([#1345](#1345)). * Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 ([#1347](#1347)). * Bump golang.org/x/sync from 0.6.0 to 0.7.0 ([#1346](#1346)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
CLI: * Don't attempt auth in `auth profiles --skip-validate` ([#1282](#1282)). * Fixed typo in error template for auth describe ([#1341](#1341)). Bundles: * Correctly transform libraries in for_each_task block ([#1340](#1340)). * Do not emit warning on YAML anchor blocks ([#1354](#1354)). * Fixed pre-init script order ([#1348](#1348)). * Execute preinit after entry point to make sure scripts are loaded ([#1351](#1351)). Dependency updates: * Bump internal terraform provider version to `1.39` ([#1339](#1339)). * Bump golang.org/x/term from 0.18.0 to 0.19.0 ([#1343](#1343)). * Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4 ([#1344](#1344)). * Bump golang.org/x/mod from 0.16.0 to 0.17.0 ([#1345](#1345)). * Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 ([#1347](#1347)). * Bump golang.org/x/sync from 0.6.0 to 0.7.0 ([#1346](#1346)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
CLI: * Don't attempt auth in `auth profiles --skip-validate` ([#1282](#1282)). * Fixed typo in error template for auth describe ([#1341](#1341)). Bundles: * Correctly transform libraries in for_each_task block ([#1340](#1340)). * Do not emit warning on YAML anchor blocks ([#1354](#1354)). * Fixed pre-init script order ([#1348](#1348)). * Execute preinit after entry point to make sure scripts are loaded ([#1351](#1351)). Dependency updates: * Bump internal terraform provider version to `1.39` ([#1339](#1339)). * Bump golang.org/x/term from 0.18.0 to 0.19.0 ([#1343](#1343)). * Bump github.com/hashicorp/hc-install from 0.6.3 to 0.6.4 ([#1344](#1344)). * Bump golang.org/x/mod from 0.16.0 to 0.17.0 ([#1345](#1345)). * Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 ([#1347](#1347)). * Bump golang.org/x/sync from 0.6.0 to 0.7.0 ([#1346](#1346)). ## Changes <!-- Summary of your changes that are easy to understand --> ## Tests <!-- How is this tested? -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In 0.217.0 we started to emit warning on unknown fields in YAML configuration but wrongly considered YAML anchor blocks as unknown field.
This PR fixes this by skipping normalising of YAML blocks.
Tests
Added regression tests