Add omitempty tag to bundle git details #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyucht
reviewed
May 1, 2023
|
Good point. Created a ticket to track it: https://databricks.atlassian.net/browse/DECO-740. We do not have any such existing tests, we rely on the red hat yaml extension to do the validation for us. However validation should be possible using a library like https://github.com/santhosh-tekuri/jsonschema |
mgyucht
approved these changes
May 1, 2023
Merged
shreyas-goenka
added a commit
that referenced
this pull request
May 15, 2023
## Changes ## 0.0.32 * Add support for variables in bundle config. Introduces 4 ways of setting variable values, which in decreasing order of priority are: ([#383](#383)). 1. Command line flag. For example: `--var="foo=bar"` 2. Environment variable. eg: BUNDLE_VAR_foo=bar 3. Default value as defined in the applicable environments block 4. Default value defined in variable definition * Make the git details bundle config block optional ([#372](#372)). * Fix api post integration tests ([#371](#371)). * Fix table of content by removing not required top-level item ([#366](#366)). * Fix printing the tasks in job output in DAG execution order ([#377](#377)). * Improved error message when 'bricks bundle run' is executed before 'bricks bundle deploy' ([#378](#378)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add omit empty tag to git details. Otherwise this field becomes a required field in the config json schema
Tests
Tested by regenerating the json schema and checking that the git field is now optional