Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config environment support for variable overriding #383

Merged
merged 3 commits into from
May 15, 2023

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented May 15, 2023

Changes

Allows to override default value for a variable definition from the environment block in a bundle config. See bundle.yml for example usage

Tests

Unit tests

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

bundle/config/variable/variable.go Outdated Show resolved Hide resolved
Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
@shreyas-goenka shreyas-goenka merged commit dd04875 into main May 15, 2023
@shreyas-goenka shreyas-goenka deleted the var-env-overrides branch May 15, 2023 12:07
@shreyas-goenka shreyas-goenka mentioned this pull request May 15, 2023
shreyas-goenka added a commit that referenced this pull request May 15, 2023
## Changes
## 0.0.32
* Add support for variables in bundle config. Introduces 4 ways of
setting variable values, which in decreasing order of priority are:
([#383](https://github.com/databricks/bricks/pull/383))([#359](https://github.com/databricks/bricks/pull/359)).
	1. Command line flag. For example: `--var="foo=bar"`
	2. Environment variable. eg: BUNDLE_VAR_foo=bar
	3. Default value as defined in the applicable environments block
	4. Default value defined in variable definition
* Make the git details bundle config block optional
([#372](#372)).
* Fix api post integration tests
([#371](#371)).
* Fix table of content by removing not required top-level item
([#366](#366)).
* Fix printing the tasks in job output in DAG execution order
([#377](#377)).
* Improved error message when 'bricks bundle run' is executed before
'bricks bundle deploy'
([#378](#378)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants