Rename: bricks -> databricks #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjakobs
commented
May 22, 2023
cmd/root/logger.go
Outdated
| envBricksLogFile = "BRICKS_LOG_FILE" | ||
| envBricksLogLevel = "BRICKS_LOG_LEVEL" | ||
| envBricksLogFormat = "BRICKS_LOG_FORMAT" | ||
| envDatabricksCliLogFile = "DATABRICKS_CLI_LOG_FILE" |
There was a problem hiding this comment.
@pietern or do we want DATABRICKS_LOG_FILE?
pietern
reviewed
May 22, 2023
cmd/root/io.go
Outdated
| @@ -8,14 +8,14 @@ import ( | |||
| "github.com/spf13/cobra" | |||
| ) | |||
|
|
|||
| const envBricksOutputFormat = "BRICKS_OUTPUT_FORMAT" | |||
| const envDatabricksCliOutputFormat = "DATABRICKS_CLI_OUTPUT_FORMAT" | |||
There was a problem hiding this comment.
This should be DATABRICKS_OUTPUT_FORMAT
cmd/root/logger.go
Outdated
| envBricksLogFormat = "BRICKS_LOG_FORMAT" | ||
| envDatabricksCliLogFile = "DATABRICKS_CLI_LOG_FILE" | ||
| envDatabricksCliLogLevel = "DATABRICKS_CLI_LOG_LEVEL" | ||
| envDataricksCliLogFormat = "DATABRICKS_CLI_LOG_FORMAT" |
There was a problem hiding this comment.
Same, we should drop the _CLI
|
@pietern I'd leave the |
pietern
approved these changes
May 22, 2023
| @@ -12,7 +12,7 @@ type Config struct { | |||
| AzureTenantId string `json:"azure_tenant_id,omitempty"` | |||
| AzureUseMsi bool `json:"azure_use_msi,omitempty"` | |||
| AzureWorkspaceResourceId string `json:"azure_workspace_resource_id,omitempty"` | |||
| BricksCliPath string `json:"bricks_cli_path,omitempty"` | |||
| DatabricksCliPath string `json:"databricks_cli_path,omitempty"` | |||
There was a problem hiding this comment.
This requires a Terraform provider bump as well -- can be done and verified async.
cmd/root/io.go
Outdated
| @@ -8,14 +8,14 @@ import ( | |||
| "github.com/spf13/cobra" | |||
| ) | |||
|
|
|||
| const envBricksOutputFormat = "BRICKS_OUTPUT_FORMAT" | |||
| const envDatabricksCliOutputFormat = "DATABRICKS_OUTPUT_FORMAT" | |||
There was a problem hiding this comment.
Please rename the symbol as well.
Merged
pietern
added a commit
that referenced
this pull request
May 23, 2023
## Changes CLI: * Sync: Gracefully handle broken notebook files ([#398](#398)). * Add version flag to print version and exit ([#394](#394)). * Pass temporary directory environment variables to subprocesses ([#395](#395)). * Rename environment variables `BRICKS_` -> `DATABRICKS_` ([#393](#393)). * Update to Go SDK v0.9.0 ([#396](#396)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
related to databricks/databricks-vscode#721
Rename env vars
BRICKS_CLI_PATH->DATABRICKS_CLI_PATHBRICKS_OUTPUT_FORMAT->DATABRICKS_OUTPUT_FORMATBRICKS_LOG_FILE->DATABRICKS_LOG_FILEBRICKS_LOG_LEVEL->DATABRICKS_LOG_LEVELBRICKS_LOG_FORMAT->DATABRICKS_LOG_FORMATBRICKS_PROGRESS_FORMAT->DATABRICKS_CLI_PROGRESS_FORMATBRICKS_UPSTREAM->DATABRICKS_CLI_UPSTREAMBRICKS_UPSTREAM_VERSION->DATABRICKS_CLI_UPSTREAM_VERSION