Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: Gracefully handle broken notebook files #398

Merged
merged 3 commits into from
May 23, 2023
Merged

Conversation

fjakobs
Copy link
Contributor

@fjakobs fjakobs commented May 23, 2023

Changes

Ignore broken notebook files during sync.

Fixes databricks/databricks-vscode#712

@fjakobs fjakobs requested a review from pietern May 23, 2023 09:57
@fjakobs fjakobs enabled auto-merge (squash) May 23, 2023 10:01
libs/sync/snapshot.go Show resolved Hide resolved
libs/sync/snapshot.go Show resolved Hide resolved
@fjakobs fjakobs merged commit aa85638 into main May 23, 2023
4 checks passed
@pietern pietern deleted the graceful-notebook branch May 23, 2023 10:10
@pietern pietern mentioned this pull request May 23, 2023
pietern added a commit that referenced this pull request May 23, 2023
## Changes

CLI:
* Sync: Gracefully handle broken notebook files
([#398](#398)).
* Add version flag to print version and exit
([#394](#394)).
* Pass temporary directory environment variables to subprocesses
([#395](#395)).
* Rename environment variables `BRICKS_` -> `DATABRICKS_`
([#393](#393)).
* Update to Go SDK v0.9.0
([#396](#396)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sync fails with empty ipynb notebook file
2 participants