Fix force flag not working for bundle destroy #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
changed the title
|
This PR together with #492 fixes |
shreyas-goenka
changed the title
shreyas-goenka
force-pushed
the
fix-destroy-force
branch
from
07cbec0
to
b3c5ae6
Compare
pietern
approved these changes
Jun 19, 2023
Merged
pietern
added a commit
that referenced
this pull request
Jun 20, 2023
## Changes This version marks the first version available as public preview. The minor bump to 200 better disambiguates between Databricks CLI "v1" (the Python version) and this version, Databricks CLI "v2". The minor version of 0.100 may look lower than 0.17 to some, whereas 200 does not. This bump has no other significance. CLI: * Add filer.Filer implementation backed by the Files API ([#474](#474)). * Add fs cp command ([#463](#463)). * Correctly set ExactArgs if generated command has positional arguments ([#488](#488)). * Do not use white color as string output ([#489](#489)). * Update README to reflect public preview status ([#491](#491)). Bundles: * Fix force flag not working for bundle destroy ([#434](#434)). * Fix locker unlock for destroy ([#492](#492)). * Use better error assertions and clean up locker API ([#490](#490)). Dependencies: * Bump golang.org/x/mod from 0.10.0 to 0.11.0 ([#496](#496)). * Bump golang.org/x/sync from 0.2.0 to 0.3.0 ([#495](#495)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
--forceflag did not exist forbundle destroy. This PR adds that in.Tests
manually tested. Now adding the
--forceflag hijacks the deploy lock on the target directory.