Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filer.Filer implementation backed by the Files API #474

Merged
merged 6 commits into from
Jun 19, 2023
Merged

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Jun 14, 2023

Tests

New integration test for the read/write parts of the other filers. The integration test cannot be shared just yet because the Files API doesn't include support for creating/listing/removing directories yet.

@pietern pietern changed the title [wip] Add filer.Filer implementation backed by the Files API Add filer.Filer implementation backed by the Files API Jun 19, 2023
@pietern pietern marked this pull request as ready for review June 19, 2023 14:47
Copy link
Contributor

@shreyas-goenka shreyas-goenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one clarification about a comment

@pietern pietern enabled auto-merge (squash) June 19, 2023 18:25
@pietern pietern merged commit e19eaca into main Jun 19, 2023
@pietern pietern mentioned this pull request Jun 20, 2023
pietern added a commit that referenced this pull request Jun 20, 2023
## Changes

This version marks the first version available as public preview.

The minor bump to 200 better disambiguates between Databricks CLI "v1" (the Python version)
and this version, Databricks CLI "v2". The minor version of 0.100 may look lower than 0.17
to some, whereas 200 does not. This bump has no other significance.

CLI:
* Add filer.Filer implementation backed by the Files API ([#474](#474)).
* Add fs cp command ([#463](#463)).
* Correctly set ExactArgs if generated command has positional arguments ([#488](#488)).
* Do not use white color as string output ([#489](#489)).
* Update README to reflect public preview status ([#491](#491)).

Bundles:
* Fix force flag not working for bundle destroy ([#434](#434)).
* Fix locker unlock for destroy ([#492](#492)).
* Use better error assertions and clean up locker API ([#490](#490)).

Dependencies:
* Bump golang.org/x/mod from 0.10.0 to 0.11.0 ([#496](#496)).
* Bump golang.org/x/sync from 0.2.0 to 0.3.0 ([#495](#495)).
@pietern pietern deleted the filer-files-api branch July 27, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants