Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bundle destroy fails when bundle.tf.json file is deleted #519

Merged

Conversation

stikkireddy
Copy link
Contributor

Changes

Adds the following steps to the destroy phase:

  1. interpolate
  2. write

Resolves #518

Tests

Tested manually due there not being an examples for tests to use.

@stikkireddy stikkireddy changed the title Fix: bundle destroy when .databricks folder is removed Fix: bundle destroy fails when bundle.tf.json file is deleted Jun 22, 2023
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the fix!

bundle/phases/destroy.go Show resolved Hide resolved
@stikkireddy stikkireddy requested a review from pietern July 5, 2023 15:29
@pietern pietern enabled auto-merge (squash) July 5, 2023 15:31
@pietern pietern disabled auto-merge July 5, 2023 19:57
@pietern pietern merged commit 533234f into databricks:main Jul 5, 2023
4 checks passed
@pietern pietern mentioned this pull request Jul 7, 2023
pietern added a commit that referenced this pull request Jul 10, 2023
## Changes

CLI:
* Fix secrets put-secret command
([#545](#545)).
* Fixed ignoring required positional parameters when --json flag is
provided ([#535](#535)).
* Update cp help message to not require file scheme
([#554](#554)).

Bundles:
* Fix: bundle destroy fails when bundle.tf.json file is deleted
([#519](#519)).
* Fixed error reporting when included invalid files in include section
([#543](#543)).
* Make top level workspace optional in JSON schema
([#562](#562)).
* Propagate TF_CLI_CONFIG_FILE env variable
([#555](#555)).
* Update Terraform provider schema structs
([#563](#563)).
* Update inline JSON schema documentation
([#557](#557)).

Dependencies:
* Bump Go SDK to v0.12.0
([#540](#540)).
* Bump github.com/hashicorp/terraform-json from 0.17.0 to 0.17.1
([#541](#541)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: bundle destroy fails with failed to instantiate provider
2 participants