Include error cause in exception raising #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is specially useful for bad requests calls
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 83.06% 83.06%
=======================================
Files 30 30
Lines 1943 1943
=======================================
Hits 1614 1614
Misses 329 329Continue to review full report at Codecov.
|
andrewmchen
reviewed
Nov 21, 2018
| @@ -106,5 +106,5 @@ def perform_query(self, method, path, data = {}, headers = None): | |||
| try: | |||
| resp.raise_for_status() | |||
| except requests.exceptions.HTTPError as e: | |||
| raise e | |||
| raise requests.exceptions.HTTPError(resp.content, e) | |||
There was a problem hiding this comment.
How does this work? Does HTTPError handle the arguments or does IOError do it?
Also, could we just use e.response where ever this exception is caught again? Not sure what the purpose of throwing this exception again is anyways actually.
|
Looks like #192 implements similar behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is specially useful for bad requests calls