Updated retry behaviour #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- retry on 500 status codes if the server operation is idempotent Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
rcypher-databricks
requested review from
mattdeekay,
susodapop,
yunbodeng-db and
andrefurlan-db
as code owners
Allow retries on calls to fetch results. The drivers handling of fetching result pages is robust enough to handle unexpected pagination due to retries. Updated the error handling to make sure that the client error handler will be called so that information in databricks response headers will be added to the error info. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
andrefurlan-db
approved these changes
May 18, 2023
| msg, start := logger.Track("ExecuteStatement") | ||
|
|
||
| // We use context.Background to fix a problem where on context done the query would not be cancelled. |
internal/client/client.go
Outdated
| } | ||
|
|
||
| // 429 Too Many Requests or 503 service unavailable is recoverable. Sometimes the server puts | ||
| // a Retry-After response header to indicate when the server is | ||
| // available to start processing request from client. | ||
| if isRetryable(resp.StatusCode) { | ||
| return true, nil | ||
| if resp.StatusCode == http.StatusTooManyRequests || resp.StatusCode == http.StatusServiceUnavailable { |
There was a problem hiding this comment.
make it a call to the function?
There was a problem hiding this comment.
gotta docuemnt that we do honour retry-after if it not 429 or 503
Simplified error message to use either X-Databricks-Reason-Phrase or X-Thriftserver-Error-Message header. Always honour Retry-After header when retrying. Not just on 429 or 503. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
| } | ||
| } | ||
| return false, nil | ||
|
|
||
| // The error is likely recoverable so retry. |
There was a problem hiding this comment.
we should probably not retry execute statement in case of network connection severed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raymond Cypher raymond.cypher@databricks.com