Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PECO-1016-2] Add handling for special types #158

Merged
merged 7 commits into from Sep 7, 2023
Merged

[PECO-1016-2] Add handling for special types #158

merged 7 commits into from Sep 7, 2023

Conversation

nithinkdb
Copy link
Contributor

@nithinkdb nithinkdb commented Aug 29, 2023 •
edited

In this PR, we add further handling to allow for special types to be set via the DBSQLParams variable.

@nithinkdb nithinkdb changed the title Add handling for new class Add handling for special types Sep 4, 2023
rcypher-databricks
rcypher-databricks reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@rcypher-databricks rcypher-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a new example showing how to run a parameterized query.
We should also add a test driver_e2e_test.go so that we have a test that exercises the interaction of our connection as a NamedValueChecker.

parameters.go Outdated Show resolved Hide resolved
parameter_test.go Show resolved Hide resolved
parameter_test.go Outdated Show resolved Hide resolved
parameters.go Outdated Show resolved Hide resolved
@nithinkdb nithinkdb changed the title Add handling for special types [PECO-1016-2] Add handling for special types Sep 7, 2023
@nithinkdb
Copy link
Contributor Author

Let's add a new example showing how to run a parameterized query. We should also add a test driver_e2e_test.go so that we have a test that exercises the interaction of our connection as a NamedValueChecker.

Created this follow up work item to track both of these: https://databricks.atlassian.net/browse/PECO-1048

@nithinkdb
Add handling for new class
c0e473a 
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
@nithinkdb
Finished impl and tests
7ce81f6 
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
@nithinkdb
Changed dbsqlparam
db3f0f1 
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
@nithinkdb
Removed void type
ddd0e53 
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
@nithinkdb
Got code working
1c348fa 
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
@nithinkdb
Fixed connection
1f59d21 
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
@nithinkdb
Fixed comments
27d9a87 
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
rcypher-databricks
rcypher-databricks approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@rcypher-databricks rcypher-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we might want to change the names of the SqlType constants but we can talk about that for the next PR.

@nithinkdb nithinkdb merged commit 73073d2 into databricks:main Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcypher-databricks rcypher-databricks rcypher-databricks approved these changes

@susodapop susodapop Awaiting requested review from susodapop

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db yunbodeng-db is a code owner

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

@jadewang-db jadewang-db Awaiting requested review from jadewang-db jadewang-db is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nithinkdb @rcypher-databricks