PECO-1054 Expose Arrow batches to users, part three #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcypher-databricks
requested review from
susodapop,
yunbodeng-db,
andrefurlan-db and
jadewang-db
as code owners
doc.go
Outdated
| conn, _ := db.Conn(context.BackGround()) | ||
| defer conn.Close() | ||
|
|
||
| query := `select * from hive_metastore.main.taxi_trip_data` |
There was a problem hiding this comment.
change to UC. main.default.<>
examples/arrrowbatches/main.go
Outdated
| ctx2, cancel2 := context.WithTimeout(context.Background(), 30*time.Second) | ||
| defer cancel2() | ||
|
|
||
| batches, err := rows.(dbsqlrows.DBSQLRows).GetArrowBatches(ctx2) |
There was a problem hiding this comment.
is DBSQL something that we actually expose externally as an acronym? Any alternatives to this?
Added DBSqlRows and DBSQLArrowBatchIterator public interfaces. Added arrowRecordIterator which implements DBSQLArrowBatchIterator. Moved closing the db operation from rows type into resultPageIterator as well as properties that are only used by resultPageIterator. Added GetArrowBatches function to rows and arrowRowScanner types. Added HasNext function to BatchIterator and SparkArrowBatch interfaces. Added example for accessing Arrow batches and updated doc.go Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Renamed DBSQLRows and DBSQLArrowBatchIterator to Rows and ArrowBatchIterator by dropping the DBSQL prefix. Updated example to use UC Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
rcypher-databricks
force-pushed
the
arrow_batches
branch
from
6930fa2
to
ea722ff
Compare
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
rcypher-databricks
force-pushed
the
arrow_batches
branch
from
442bd9e
to
e42a5db
Compare
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DBSqlRows and DBSQLArrowBatchIterator public interfaces.
Added arrowRecordIterator which implements DBSQLArrowBatchIterator.
Moved closing the database operation from rows type into resultPageIterator as well as properties that are only used by resultPageIterator.
Added GetArrowBatches function to rows and arrowRowScanner types.
Added HasNext function to BatchIterator and SparkArrowBatch interfaces.
Added example for accessing Arrow batches and updated doc.go