Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improvements #172

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Logging improvements #172

merged 5 commits into from
Oct 12, 2023

Commits on Oct 10, 2023

  1. Logging improvements 

    Differentiated some cases where the logged messages were ambiguous as to which code path they came from.
Updated client to be more consistent in what context information is included in logging messages.

Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    332b8cb View commit details
    Browse the repository at this point in the history

  2. Log execution status/state and fix flaw in cancel logic. 

    Logging status/state returned by executing a statement.
The logic for handling context cancel/timeout was not working correctly in the case where there are no direct results returned from execute statement.
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2a813ac View commit details
    Browse the repository at this point in the history

  3. Fixed case where incorrect error is being logged 

    Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    6b4fce7 View commit details
    Browse the repository at this point in the history

  4. Log DisplayMessage in thrift responses 

    Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks
    rcypher-databricks committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    1d02905 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Update internal/client/client.go 

    Co-authored-by: Jesse <jwhitehouse@airpost.net>
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
    @rcypher-databricks @susodapop
    rcypher-databricks and susodapop committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3df5f70 View commit details
    Browse the repository at this point in the history