Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DriverVersion in Config to 1.0.1 #94

Merged
merged 3 commits into from Jan 23, 2023

Conversation

mattdeekay
Copy link
Contributor

@mattdeekay mattdeekay commented Jan 13, 2023

Description

In this PR, we update the driver version to 1.0.1 to reflect the latest cut. We also move the DriverVersion to a more visible const in driver.go.

(Already merged) Most of the code in driver.go:Open is the same as driver.go:OpenConnector so these are merged.

Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
connector_test.go Outdated Show resolved Hide resolved
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Copy link
Contributor

@andrefurlan-db andrefurlan-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this. Let's see how it goes, but I feel like having a version package would make it easier to find and also use in any other package

@mattdeekay mattdeekay merged commit 39dbe07 into databricks:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants