Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLAlchemy dialect has_table doesn't use the schema name. #115

Closed
unj1m opened this issue May 2, 2023 · 2 comments · Fixed by #174
Closed

SQLAlchemy dialect has_table doesn't use the schema name. #115

unj1m opened this issue May 2, 2023 · 2 comments · Fixed by #174
Assignees
@susodapop

Comments

@unj1m
Copy link
Contributor

unj1m commented May 2, 2023

has_table gets the schema namebut doesn't pass it to DESCRIBE.

This causes SQLAlchemy to fail to drop a given table (in a given schema).
@unj1m unj1m changed the title SQLAlchemy dialect has_table doesn't ise the schema name. SQLAlchemy dialect has_table doesn't use the schema name. May 2, 2023
@narquette
Copy link

narquette commented Jul 10, 2023 •
edited

Agree. Having the same experience. This is a simple fix. I've changed it locally (allowed for schema name to get passed to DESCRIBE TABLE) and it works without issue.

@narquette
Copy link

@susodapop Can we get someone assigned to this ticket?

@susodapop susodapop self-assigned this Jul 11, 2023
susodapop added a commit that referenced this issue Jul 11, 2023
@susodapop
Update has_table to honor schema selection and allow for catalog select
530e2bd 
Closes #115

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
This was referenced Jul 11, 2023
Merged
Closed
susodapop added a commit that referenced this issue Jul 11, 2023
@susodapop
Update has_table to honor schema selection and allow for catalog select
2388873 
Closes #115

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop added a commit that referenced this issue Jul 12, 2023
@susodapop
Update has_table to honor schema selection and allow for catalog select
159355d 
Closes #115

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susodapop susodapop

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@susodapop @narquette @unj1m