Filter databricks-sql-connector logs to warn or higher #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db,
susodapop and
rcypher-databricks
as code owners
rcypher-databricks
previously approved these changes
Sep 6, 2023
susodapop
previously approved these changes
Sep 6, 2023
| @@ -3,6 +3,7 @@ | |||
| ### Fixes | |||
|
|
|||
| - Improved legibility of python stack traces ([#434](https://github.com/databricks/dbt-databricks/pull/434)). | |||
| - Streamlined sql connector output in dbt.log ([#437](https://github.com/databricks/dbt-databricks/pull/437)) | |||
There was a problem hiding this comment.
Can we please please please fix your auto formatter settings so we don't get so many changed lines in your pull requests 🙏 ?
benc-db
dismissed stale reviews from susodapop and rcypher-databricks
via
b9533a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #432
Description
databricks-sql-connector is chatty, which ends up making dbt logs harder to read. Setting level to WARN by default, so that issues still make it through, but we don't see extra details about every connection initiated and closed.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.