Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_info to SQLQuery events #494

Conversation

davidharting
Copy link
Contributor

@davidharting davidharting commented Oct 30, 2023

Description

This is a follow-up to #453, which added node_info to the SQLQueryStatus event. This PR adds node_info to the SQLQuery event.

I did not open a separate issue for this as it feels very related to #452, but happy to log a new issue if desired!

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

PR Status

Keeping this as draft for the moment while I get set up to run the linter and add a changelog entry.

@davidharting
Copy link
Contributor Author

Looks like lint passed, going to move to ready for review.

$ tox -e linter
linter: commands[0]> .tox/linter/bin/python -m black --config black.ini --check dbt tests
All done! ✨ 🍰 ✨
78 files would be left unchanged.
linter: commands[1]> .tox/linter/bin/python -m flake8 --select=E,W,F --ignore=E203,W503 --max-line-length=100 dbt tests
linter: commands[2]> .tox/linter/bin/python -m mypy --config-file mypy.ini --explicit-package-bases dbt tests
tests/integration/streaming_table/test_streaming_table.py:39: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
tests/integration/streaming_table/test_streaming_table.py:49: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
tests/integration/run_results_json/test_run_results_json.py:9: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
tests/integration/materialized_view/test_materialized_view.py:37: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
tests/integration/materialized_view/test_materialized_view.py:47: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
tests/unit/test_adapter.py:844: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
tests/unit/test_adapter.py:865: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
tests/unit/test_adapter.py:876: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
tests/unit/test_adapter.py:889: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
Success: no issues found in 78 source files
  linter: OK (10.53=setup[0.03]+cmd[0.19,0.36,9.94] seconds)
  congratulations :) (10.57 seconds)

@davidharting
Copy link
Contributor Author

I am going on parental leave, so I am transitioning author-responsibilities for this PR over to @colin-rogers-dbt capable hands.

@benc-db benc-db merged commit c1aff5b into databricks:main Nov 7, 2023
18 checks passed
@davidharting
Copy link
Contributor Author

Thank you so much @benc-db!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants