-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's use 'kser' rather than 'ks' or 's' as variable name for Series #1052
Let's use 'kser' rather than 'ks' or 's' as variable name for Series #1052
Conversation
@ueshin @HyukjinKwon Could you please let me know your opinion after confirm this PR when you guys available? 😄 |
Codecov Report
@@ Coverage Diff @@
## master #1052 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 34 34
Lines 6765 6765
=======================================
Hits 6436 6436
Misses 329 329
Continue to review full report at Codecov.
|
Shall we fix some more?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Looks good except Takuya's comments too.
@ueshin, @HyukjinKwon Thanks for the comment! i just fix the missing ones. |
Shall we fix too?
|
@ueshin Thanks for finding! :) |
Softagram Impact Report for pull/1052 (head commit: 9e11056)⭐ Change Overview
💡 Insights
📄 Full report
Impact Report explained. Give feedback on this report to support@softagram.com |
Merged to master. |
Since the
ks
is used as koalas' import naming convention we recommended likefrom databricks.koalas as ks
Let's don't use
ks
as variable name for Series, usekser
instead for unity & readability of our codes and to avoid confusing.Plus, i think maybe we better also avoid using of just
s
as possible for more readability.