Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's use 'kser' rather than 'ks' or 's' as variable name for Series #1052

Merged
merged 4 commits into from
Nov 18, 2019

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Nov 18, 2019

Since the ks is used as koalas' import naming convention we recommended like from databricks.koalas as ks

Let's don't use ks as variable name for Series, use kser instead for unity & readability of our codes and to avoid confusing.

Plus, i think maybe we better also avoid using of just s as possible for more readability.

@itholic
Copy link
Contributor Author

itholic commented Nov 18, 2019

@ueshin @HyukjinKwon Could you please let me know your opinion after confirm this PR when you guys available? 😄

@itholic itholic changed the title Let's use 'kser' rather than 'ks' or 's' for Series as variable name Let's use 'kser' rather than 'ks' or 's' as variable name for Series Nov 18, 2019
@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #1052 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1052   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files          34       34           
  Lines        6765     6765           
=======================================
  Hits         6436     6436           
  Misses        329      329
Impacted Files Coverage Δ
databricks/koalas/indexing.py 94.89% <100%> (ø) ⬆️
databricks/koalas/generic.py 95.73% <100%> (ø) ⬆️
databricks/koalas/groupby.py 91.39% <100%> (ø) ⬆️
databricks/koalas/window.py 97.1% <100%> (ø) ⬆️
databricks/koalas/frame.py 96.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169e38e...9e11056. Read the comment docs.

@ueshin
Copy link
Collaborator

ueshin commented Nov 18, 2019

Shall we fix some more?

  • frame.py: There are two for name, ks in kdf.iteritems():
  • test_dataframe.py: There are some right_ks.

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Looks good except Takuya's comments too.

@itholic
Copy link
Contributor Author

itholic commented Nov 18, 2019

@ueshin, @HyukjinKwon Thanks for the comment! i just fix the missing ones.

@ueshin
Copy link
Collaborator

ueshin commented Nov 18, 2019

Shall we fix too?

test_dataframe.py: There are some right_ks.

@itholic
Copy link
Contributor Author

itholic commented Nov 18, 2019

@ueshin Thanks for finding! :)

@softagram-bot
Copy link

Softagram Impact Report for pull/1052 (head commit: 9e11056)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

💡 Insights

  • Co-change Alert: You modified test_frame_plot.py. Often plot.py (databricks/koalas) is modified at the same time.

📄 Full report

Impact Report explained. Give feedback on this report to support@softagram.com

@HyukjinKwon HyukjinKwon merged commit 221b5a2 into databricks:master Nov 18, 2019
@HyukjinKwon
Copy link
Member

Merged to master.

@itholic itholic deleted the dont_use_ks_as_variable_name branch November 19, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants